Collect code coverage and enforce minimum coverage on CI #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used to measure code coverage
rmacklin
force-pushed
the
measure-code-coverage
branch
2 times, most recently
from
548bcba to
cef5ad2
Compare
Coverage will only be measured if the `MEASURE_COVERAGE=true` environment variable is set. We'll set that on CI, but for local runs we won't need to collect code coverage every single time we run the tests.
Let's prevent our test coverage from dropping
The coverage report will be uploaded as an artifact so that anyone can inspect the results.
rmacklin
force-pushed
the
measure-code-coverage
branch
from
cef5ad2 to
8729d49
Compare
We don't need to measure coverage for each run since we don't have logic that's conditional on the ruby version or the rack version. Furthermore, it seems like when all of the jobs try to upload the coverage artifact, some of them fail with ``` Error: Unexpected response. Unable to upload chunk to https://pipelines.actions.githubusercontent.com/Rno49s13pA5vllnyZeZXc7qQF0b4Jq8BZ4WgDbFQX4NocZwQsY/_apis/resources/Containers/14397?itemPath=code-coverage-report%2Fassets%2F0.12.3%2Fcolorbox%2Floading.gif ``` as seen in https://github.com/miyagawa/rack-vcr/runs/1337619960?check_suite_focus=true So, let's only measure coverage for the job running the latest ruby and rack versions.
rmacklin
force-pushed
the
measure-code-coverage
branch
from
8729d49 to
79242ec
Compare
|
@miyagawa Any interest in this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
simplecovand uses it to measure code coverage and enforce test coverage on CI.Example coverage report screenshots