-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct installdeps docs to note it's following extra rules #529
base: devel
Are you sure you want to change the base?
Conversation
7ed4df8
to
5102a4e
Compare
@@ -869,7 +869,7 @@ Options: | |||
-n,--notest Do not run unit tests | |||
--test-only Run tests only, do not install | |||
-S,--sudo sudo to run install commands | |||
--installdeps Only install dependencies | |||
--installdeps Only install 'test' dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don' think calling them 'test' is the right wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the wording from the in-code comment at https://github.com/miyagawa/cpanminus/blob/devel/lib/App/cpanminus/script.pm#L2212
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's an explanation why test
is included in some situations and not in others.
5102a4e
to
45fe7ba
Compare
Removed the bit about |
Well, |
So, about the names, do you disagree with the wording in the in-code comment then? How would you word it? I'm happy to adjust both the docs further and include that comment too. |
Ah, didn't see the comment in the review bit, sorry. No editing the comment then. Still curious how you'd word that then? It's important to me that any doc talking about it makes it clear that it will skip some of the deps in cpanfile. |
I would call it "runtime/test dependencies" if you want to be specific. The fact "build" is included is an artifact that "test" dependencies only exist in META spec v2. |
As discussed, this patch corrects the description of installdeps in various places to stop it giving the appearance of installing all dependencies.
Relates to #528