tools/update_news_date: Fix script for squash-and-merge strategy#242
Merged
daschuer merged 1 commit intomixxxdj:websitefrom May 16, 2021
Merged
Conversation
Holzhaus
commented
May 9, 2021
Holzhaus
force-pushed
the
update-news-date-squash-and-merge
branch
from
3cb2390 to
affb7fa
Compare
daschuer
approved these changes
May 16, 2021
Member
daschuer
left a comment
daschuer
left a comment
There was a problem hiding this comment.
Looks reasonable. So let's test it next time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merging a blog post using squash-and-merge, no merge commit is created. This makes the
update_news_date.pyscript fail because it can't find the corresponding merge commit. This was the case for #217. It only worked when #240 was merged, because now the blog post was part of a merge commit (see https://github.com/mixxxdj/website/runs/2536666268?check_suite_focus=true)This fixes the issue by supporting squash-and-merge, too.