add option to generate waveforms on analysis#998
Conversation
|
|
||
| bool waveformGenerateWithAnalysisEnabled() const { | ||
| return m_pConfig->getValue<bool>( | ||
| ConfigKey("[Library]", "GenerateWaveformsWithAnalysis"), true); |
There was a problem hiding this comment.
The naming is inconsistent in various aspects. The new option in the config file uses a different wording for functions and the corresponding key in the config file: "waveform generate" (singular) vs. "generate waveforms" (plural) and ordering of words. And it also differs from the naming of related config options, namely "EnableWaveformCaching" -> "waveform caching enabled".
I would propose to follow the existing naming scheme for related options. Even if we don't like the current scheme, at least it is easier to remember if it is consistent.
There was a problem hiding this comment.
Thanks for point that out. I didn't think much about the naming. Fixed.
| AnalyzerQueue* ret = new AnalyzerQueue(pTrackCollection); | ||
|
|
||
| if (pConfig->getValue<bool>(ConfigKey("[Library]", "GenerateWaveformsWithAnalysis"))) { | ||
| if (pConfig->getValue<bool>(ConfigKey("[Library]", "EnableWaveformGenerationWithAnalysis"))) { |
There was a problem hiding this comment.
This is a very long name, but it is clear. Anyone have a suggestion for a shorter name that is still clear?
|
EnableWaveformGenerationWithAnalysis works for me. |
|
Yes, ready for merge. |
|
LGTM Thank you! |
3 participants
Taking care of https://bugs.launchpad.net/mixxx/+bug/1617589
Adds a new checkbox to Preferences > Interface > Waveforms > Caching:
