Added multi import for crates and playlists#945
Added multi import for crates and playlists#945rryan merged 5 commits intomixxxdj:masterfrom jmigual:hotfix/addMultiImportPlaylists
Conversation
| if (playlist_file.isEmpty()) return; | ||
|
|
||
| QFileInfo fileName(playlist_file); | ||
| // Get file to read |
|
Thank you @jmigual! This is looking good other than my tiny nits. |
Still needs to move `activateChild()` outside the function
Removed unnecessary `activateCrate()` and `activatePlaylist()`
|
Thank you Joan. LGTM |
|
Thanks Joan! For future reference, please follow the style of attaching the reference modifier to the type instead of the variable:
Please check out http://www.mixxx.org/wiki/doku.php/coding_guidelines to see our style guide. I'm hopeful that we can switch to using clang-format to end discussions around this but for now we should aim to keep the codebase uniform where possible for readability and code health. |
|
Ok, fixed. Is there any file for clang-format style for mixxx that I can be found? |
We're still working one out -- hopefully we can submit a .clang-format file to master soon so it will do the right thing when you run clang-format. |
|
Thank you for the fixes! |
…ates root element. See mixxxdj/mixxx#945. Emphasize, that importing from existing playlists/crates will result in bulk-adding the content to the single selected playlist/crate.
As discussed in https://bugs.launchpad.net/mixxx/+bug/1108371 now there's the option to import multiple playlists / crates at once