Skip to content

Added multi import for crates and playlists#945

Merged
rryan merged 5 commits intomixxxdj:masterfrom
jmigual:hotfix/addMultiImportPlaylists
May 9, 2016
Merged

Added multi import for crates and playlists#945
rryan merged 5 commits intomixxxdj:masterfrom
jmigual:hotfix/addMultiImportPlaylists

Conversation

@jmigual
Copy link
Copy Markdown
Contributor

@jmigual jmigual commented May 6, 2016

As discussed in https://bugs.launchpad.net/mixxx/+bug/1108371 now there's the option to import multiple playlists / crates at once

if (playlist_file.isEmpty()) return;

QFileInfo fileName(playlist_file);
// Get file to read
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment is duplicated?

@rryan
Copy link
Copy Markdown
Member

rryan commented May 6, 2016

Thank you @jmigual! This is looking good other than my tiny nits.

jmigual added 2 commits May 7, 2016 08:49
Still needs to move `activateChild()` outside the function
Removed unnecessary `activateCrate()` and `activatePlaylist()`
@daschuer
Copy link
Copy Markdown
Member

daschuer commented May 9, 2016

Thank you Joan. LGTM
@rryan: To you as well?

@rryan
Copy link
Copy Markdown
Member

rryan commented May 9, 2016

Thanks Joan!

For future reference, please follow the style of attaching the reference modifier to the type instead of the variable:

const QString& playlistFile instead of const QString &playlistFile

Please check out http://www.mixxx.org/wiki/doku.php/coding_guidelines to see our style guide.

I'm hopeful that we can switch to using clang-format to end discussions around this but for now we should aim to keep the codebase uniform where possible for readability and code health.

@jmigual
Copy link
Copy Markdown
Contributor Author

jmigual commented May 9, 2016

Ok, fixed. Is there any file for clang-format style for mixxx that I can be found?

@rryan
Copy link
Copy Markdown
Member

rryan commented May 9, 2016

Ok, fixed. Is there any file for clang-format style for mixxx that I can be found?

We're still working one out -- hopefully we can submit a .clang-format file to master soon so it will do the right thing when you run clang-format.

@rryan
Copy link
Copy Markdown
Member

rryan commented May 9, 2016

Thank you for the fixes!

@rryan rryan merged commit 4aa1299 into mixxxdj:master May 9, 2016
@jmigual jmigual deleted the hotfix/addMultiImportPlaylists branch May 10, 2016 08:58
@esbrandt esbrandt mentioned this pull request Jun 24, 2017
37 tasks
esbrandt added a commit to esbrandt/manual that referenced this pull request Apr 14, 2018
…ates root element. See mixxxdj/mixxx#945.

Emphasize, that importing from existing playlists/crates will result in bulk-adding the content to the single selected playlist/crate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants