Dj compact by ywwg · Pull Request #918 · mixxxdj/mixxx

ywwg · 2016-04-07T01:39:03Z

I need to do a little testing but I think this is good enough for initial commit.

feel free to bikeshed the naming scheme

It's possible to send different light information when Shift is held. For now we just send the same lights either way.

Be-ing · 2016-04-07T02:31:29Z

+}
+
+HercDJCompact.init = function(id) {
+    scratch = false;


Should this be an array to keep track of it for each deck?

Nevermind, I see that this device has a single "Scratch" button for both decks. It'd be helpful to add a comment here about that.

Be-ing · 2016-04-07T02:35:35Z

Do you plan on documenting this now or when you finish the mapping? There's already a wiki page started for a different, unfinished mapping: http://mixxx.org/wiki/doku.php/hercules_djcontrol_compact

Be-ing · 2016-04-07T02:39:55Z

+            }
+        }
+
+        if(engine.getValue(input.group, "scratch2_enable")) {


IMO the code would be easier to understand if this was moved up above line 52. I wasn't clear what lines 54-56 did until I read this far.

Be-ing · 2016-04-07T03:05:10Z

Looks good so far other than the minor issues pointed out above. There's not much more to comment on without documentation.

Be-ing · 2016-04-07T03:13:43Z

Before @sblaisot has to jump in to say it :P
Update the Windows uninstaller to include the new files: https://mixxx.org/wiki/doku.php/contributing_mappings#windows_installer_update

ywwg · 2016-04-07T13:27:42Z

Do you plan on documenting this now or when you finish the mapping? There's already a wiki page started for a different, unfinished mapping: http://mixxx.org/wiki/doku.php/hercules_djcontrol_compact

I was given this controller by hercules for the purpose of making an official mapping, so yes I'll be documenting it. As I stated this is just an initial commit.

sblaisot · 2016-04-08T15:19:51Z

please add file removal from windows uninstaller
https://mixxx.org/wiki/doku.php/contributing_mappings#windows_installer_update

EDIT : Damn it! @Be-ing has been faster than me ;)

Be-ing · 2016-04-11T06:24:02Z

+            "HercDJCompact.OnRecordingStatusChange");
+
+    // Tell controller to send midi to update knob and slider positions.
+    midi.sendShortMsg(0xB0, 0x7F, 0x7F);


Cool! I didn't see anything about this in the P32 MIDI documentation, but it works on that too! :)

yeah it's a great feature. (It was doc'ed in the pdf on hercules' site). I'm really impressed with the midi programming on this controller, a lot of convenience features.

I tried this with my Electrix Tweaker just to see if it would work but it didn't. Is this a Hercules thing? I think I recall looking at one other mapping that had such a feature, but I don't remember what mapping it was or what MIDI signal was sent.

my vestax VCI400 just does it on connect, for instance, no midi trigger required. It's certainly not any sort of standard, so I'd guess that someone at Hercules thought it up and they reuse firmwares on multiple devices.

ywwg · 2016-04-30T15:11:59Z

notes addressed

Be-ing · 2016-04-30T18:10:24Z

Hm, considering this controller lacks a high EQ knob, would it be helpful to (optionally?) map the mid EQ knob to the HPF (QuickEffect parameter3) or QuickEffect superknob?

ywwg · 2016-04-30T18:37:38Z

I am writing a framework for creating "controller preferences," which will allow this type of setting to be changed in the UI. For now I'll add a comment that users can remap the knob with the midi wizard (rather than adding javascript), or maybe even put some comments in the xml about how to do this.

When controller prefs comes in, I'll make a proper set of preferences for the knob.

It is a little silly that it's set to "mid" :/.

Be-ing · 2016-04-30T18:50:34Z

I am writing a framework for creating "controller preferences," which will allow this type of setting to be changed in the UI.

Awesome!

For now I'll add a comment that users can remap the knob with the midi wizard (rather than adding javascript), or maybe even put some comments in the xml about how to do this.

Sounds good.

Be-ing · 2016-04-30T18:51:48Z

+                </options>
+            </control>
+            <control>
+                <group>[EqualizerRack1_[Channel2]_Effect1]</group>


Would it be better to use the description element for this? That shows up in the mapping GUI.

the description tells them to edit the XML, but I don't think that's the place to go into this detail. This comment is right at the top of the file so if someone does get as far as editing the XML, they'll find it (I hope)

Alright, fine to leave it as is then

ywwg · 2016-04-30T19:03:01Z

lgty?

Be-ing · 2016-04-30T19:56:39Z

+        <name>Hercules DJControl Compact</name>
+        <author>Owen Williams</author>
+        <description>Controller mapping for Hercules DJControl Compact.  Users
+who want the labelled "mid" knob to adjust high eq instead may use the midi


spelling: "labeled"

Be-ing · 2016-04-30T20:00:50Z

JSHint warnings:
res/controllers/Hercules-DJControl-Compact-scripts.js: line 4, col 17, Weird construction. Is 'new' necessary?
res/controllers/Hercules-DJControl-Compact-scripts.js: line 6, col 1, Missing '()' invoking a constructor.
res/controllers/Hercules-DJControl-Compact-scripts.js: line 6, col 2, Missing semicolon.
res/controllers/Hercules-DJControl-Compact-scripts.js: line 52, col 19, Use '!==' to compare with '0'.
res/controllers/Hercules-DJControl-Compact-scripts.js: line 72, col 19, Use '!==' to compare with '0'.
res/controllers/Hercules-DJControl-Compact-scripts.js: line 83, col 2, Missing semicolon.

Be-ing · 2016-04-30T20:14:12Z

I'm guessing the beatlooproll_X_activate mappings are for loop mode with shift pressed. Is that correct? Could you document the mapping on http://mixxx.org/wiki/doku.php/hercules_djcontrol_compact ? I think 2x2 tables describing the pad functionality in each mode would be helpful.

Be-ing · 2016-04-30T20:16:51Z

I am writing a framework for creating "controller preferences," which will allow this type of setting to be changed in the UI.

A bit off topic, but how do you intend to implement this? I think passing a QScriptValue containing all the options to the script's init function could work well.

ywwg · 2016-04-30T22:09:06Z

wiki will be updated after this is in.

RJ and I have been collaborating on a design for controller preferences, it's similar to what you describe. Once it's settled I'll post the design doc to the mailing list.

ywwg · 2016-05-03T22:23:22Z

ping

Be-ing · 2016-05-04T00:27:30Z

As I said before, there isn't much to comment on without having documentation to reference. I can't tell if it looks good unless I wen through the MIDI documentation for this device and compared it to the XML.

ywwg · 2016-05-04T01:04:51Z

you're not expected to go through every button in/out and confirm that it's correct, this review is mostly for the style of the javascript functions. I've gone through all the buttons and functions I've mapped and made sure the controller functions nicely.

ywwg · 2016-12-11T20:57:08Z

updated documentation. Most functions are the same as manual (linked on wiki), differences are noted. http://mixxx.org/wiki/doku.php/djcontrol_compact

Be-ing · 2016-12-11T23:19:13Z

Thanks for documenting it. I added pictures of the device to the wiki from the other wiki page, reorganized the page, and made some edits. There is so little information to convey that I think referring users to Hercules' manual is more of an annoyance, so I put the little bit of information from there onto the wiki. Please confirm that it's all correct.

I like the way you've mapped the pads in loop mode. That is more flexible than the way described in Hercules' manual.

I think it would be a better use of the sampler buttons to map the left side to samplers 1-4 and right side to samplers 5-8.

It doesn't look like you have mapped shift+play to anything. I find it useful to map this to start_stop (go to beginning of track and stop).

After the changes in progress for the effects UI (see PRs #1062, #1063, #1068), I think the mapping for the effects pad mode should be reconsidered. I think enabling deck 1 for EffectUnit1 and deck 2 for EffectUnit 2 in the init function with each side toggling the effects within the EffectUnits would make sense. Shift + a pad could cycle to the next effect.

ywwg · 2016-12-12T00:39:21Z

There's a word or two missing in your edit of the jog wheel instructions: "Enable keylock on a deck by clicking the if you do not want the pitch to change when adjusting the tempo."

I'll let you know when I've addressed the notes.

ywwg · 2016-12-18T23:16:37Z

Mixxx only has 4 samplers on startup, so specifying samplers 5-8 causes a warning to appear

ywwg · 2016-12-18T23:34:03Z

Do any of our skins support more than four samplers? It doesn't look like either Latenite nor Deere do

Fix jog wheels while playing Change samplers, although those samplers don't exist

Be-ing · 2016-12-18T23:58:45Z

Mixxx only has 4 samplers on startup, so specifying samplers 5-8 causes a warning to appear

Create more by setting [Master],num_samplers to 8 in the script's init() function.

Do any of our skins support more than four samplers? It doesn't look like either Latenite nor Deere do

Yes, Deere does by flipping through the multiple pages of samplers available. It's clunky, but it's there.

ywwg · 2016-12-21T21:02:03Z

Create more by setting [Master],num_samplers to 8 in the script's init() function.

done

Be-ing · 2016-12-21T22:01:28Z

LGTM 👍

ywwg added 3 commits April 3, 2016 16:17

Hercules DJControl Compact: Initial commit, many functions working

a1c4ebf

DJControl Compact: Finish mapping

9b9f382

It's possible to send different light information when Shift is held. For now we just send the same lights either way.

DJControl Compact: tabs to spaces

949119b

Be-ing reviewed Apr 7, 2016
View reviewed changes

Be-ing reviewed Apr 11, 2016
View reviewed changes

ywwg added 2 commits April 30, 2016 09:15

Merge branch 'master' into dj-compact

2ad20dc

DJ Compact: last fixes, correct filenames

4f849b7

ywwg added 2 commits April 30, 2016 14:42

DJControl Compact: Give the user some help for remapping the mid knob

383d5d0

english

7b609c4

Be-ing reviewed Apr 30, 2016
View reviewed changes

DJControl Compact: last notes

79ea68d

ywwg added 3 commits December 11, 2016 12:39

Merge branch 'master' into dj-compact

d86320b

DJControl: Add hotcue clear buttons

dae427e

DJControl Compact: fix autodj binding

59f3eae

Add shift-play behavior

0aeccce

Fix jog wheels while playing Change samplers, although those samplers don't exist

DJ Compact: set sampler count to 8

d80fbed

ywwg merged commit 4c2419d into mixxxdj:master Dec 22, 2016

ywwg deleted the dj-compact branch December 22, 2016 01:19

Uh oh!

Conversation

ywwg commented Apr 7, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Be-ing commented Apr 7, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Be-ing commented Apr 7, 2016

Uh oh!

Be-ing commented Apr 7, 2016

Uh oh!

ywwg commented Apr 7, 2016

Uh oh!

sblaisot commented Apr 8, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ywwg commented Apr 30, 2016

Uh oh!

Be-ing commented Apr 30, 2016

Uh oh!

ywwg commented Apr 30, 2016

Uh oh!

Be-ing commented Apr 30, 2016

Uh oh!

Be-ing Apr 30, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ywwg commented Apr 30, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Be-ing commented Apr 30, 2016

Uh oh!

Be-ing commented Apr 30, 2016

Uh oh!

Be-ing commented Apr 30, 2016

Uh oh!

ywwg commented Apr 30, 2016

Uh oh!

ywwg commented May 3, 2016

Uh oh!

Be-ing commented May 4, 2016

Uh oh!

ywwg commented May 4, 2016

Uh oh!

ywwg commented Dec 11, 2016

Uh oh!

Be-ing commented Dec 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ywwg commented Dec 12, 2016

Uh oh!

ywwg commented Dec 18, 2016

Uh oh!

ywwg commented Dec 18, 2016

Uh oh!

Be-ing commented Dec 18, 2016

Uh oh!

ywwg commented Dec 21, 2016

Uh oh!

Be-ing commented Dec 21, 2016

Uh oh!

Reviewers

Be-ing Apr 30, 2016 •

edited

Loading

Be-ing commented Dec 11, 2016 •

edited

Loading