Add an option to replace the autoDJ queue with the selected tracks#915
Closed
potocpav wants to merge 2 commits intomixxxdj:masterfrom
potocpav:replace-autodj-queue
Closed
Add an option to replace the autoDJ queue with the selected tracks#915potocpav wants to merge 2 commits intomixxxdj:masterfrom potocpav:replace-autodj-queue
potocpav wants to merge 2 commits intomixxxdj:masterfrom
potocpav:replace-autodj-queue
Conversation
| return false; | ||
| } | ||
|
|
||
| // TODO: Deduplicate with deletePlaylist? |
Member
There was a problem hiding this comment.
Yes, this would be nice. This will also allow to clan up the double transaction and emit(changed(playlistId)) in the new replaceTracksInPlaylist.
Contributor
Author
|
I'm sorry, I don't have time to work on this now, I have much to do on my thesis. |
Member
|
Hi @potocpav -- do you have more time to work on this now? It would be nice to have this feature :). |
Contributor
Author
|
Yes I do. Working on it. |
Contributor
Author
|
I messed up my fork, so I made a new PR. Closing in favor of #1163. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug report: https://bugs.launchpad.net/mixxx/+bug/1566206