Electrix Tweaker mapping small updates#912
Merged
rryan merged 5 commits intomixxxdj:masterfrom May 6, 2016
Merged
Conversation
This turns off the -/+ buttons on screen; otherwise they stay lit after adjusting the loop size.
User reported this can cause Mixxx to hang with Hercules P32 mapping: http://mixxx.org/forums/viewtopic.php?f=7&t=8132
| } | ||
| } else if (engine.getValue(group, 'track_samples')) { | ||
| midi.sendShortMsg(0x90, ElectrixTweaker.buttons[group]['play'], ElectrixTweaker.colorCodes['red']) | ||
| if (control == 'cue_indicator' && value == 1) { |
Contributor
Author
There was a problem hiding this comment.
Generally, yes, but I was keeping it internally consistent with the rest of the script. I plan on rewriting the script (with better style) after finishing the P32 mapping to continue refining the JS library I'm working on with the P32 mapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a small bug and make use of cue_indicator with the multicolored play buttons