Skip to content

Added random sort "easter egg" and added tooltip for the random sort#908

Merged
daschuer merged 2 commits intomixxxdj:masterfrom
jmigual:jmigual_fixes
Mar 23, 2016
Merged

Added random sort "easter egg" and added tooltip for the random sort#908
daschuer merged 2 commits intomixxxdj:masterfrom
jmigual:jmigual_fixes

Conversation

@jmigual
Copy link
Copy Markdown
Contributor

@jmigual jmigual commented Mar 22, 2016

Hello,
I have added thhe random sort discussed in bug #1447082

The random sort is discused in bug \# 1447082
@daschuer
Copy link
Copy Markdown
Member

Thank you for the PR. It works :-)
On order to merge this, you need to become a contributor.
Please sign: https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ

and comment here when done.

Comment thread src/library/librarytablemodel.cpp Outdated
BaseSqlTableModel::setSort(column, order);

// Random sort easter egg, only in library view
if (column == 1) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use
fieldIndex(ColumnCache::COLUMN_LIBRARYTABLE_PREVIEW)
to make the code robust against future changes.

@daschuer
Copy link
Copy Markdown
Member

Some extra findings, but nothing that stops us from merging:

Playing with it the sorting arrow on the preview header feels misplaces since random has no reverse.

It would be cool to have a the soring hierarchy working with random.
Use case. sort random and than sort by star rating. Result: random soring of all 5 star tracks.

@jmigual
Copy link
Copy Markdown
Contributor Author

jmigual commented Mar 23, 2016

Ok, now I've made the changes and signed to become a contributor :)

@daschuer
Copy link
Copy Markdown
Member

Thank you. Are you working on the hierarchical random sort or should we merge this as it is?

@jmigual
Copy link
Copy Markdown
Contributor Author

jmigual commented Mar 23, 2016

I think we would better merge as it is, but we can add it to the wishlist.

@daschuer daschuer merged commit f28af32 into mixxxdj:master Mar 23, 2016
esbrandt added a commit to esbrandt/manual that referenced this pull request Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants