Added random sort "easter egg" and added tooltip for the random sort#908
Added random sort "easter egg" and added tooltip for the random sort#908daschuer merged 2 commits intomixxxdj:masterfrom jmigual:jmigual_fixes
Conversation
The random sort is discused in bug \# 1447082
|
Thank you for the PR. It works :-) and comment here when done. |
| BaseSqlTableModel::setSort(column, order); | ||
|
|
||
| // Random sort easter egg, only in library view | ||
| if (column == 1) { |
There was a problem hiding this comment.
Use
fieldIndex(ColumnCache::COLUMN_LIBRARYTABLE_PREVIEW)
to make the code robust against future changes.
|
Some extra findings, but nothing that stops us from merging: Playing with it the sorting arrow on the preview header feels misplaces since random has no reverse. It would be cool to have a the soring hierarchy working with random. |
|
Ok, now I've made the changes and signed to become a contributor :) |
|
Thank you. Are you working on the hierarchical random sort or should we merge this as it is? |
|
I think we would better merge as it is, but we can add it to the wishlist. |
Hello,
I have added thhe random sort discussed in bug #1447082