Controller mapping update for 4-mx

[JosepMaJAZ]

Controller mapping update for 4-mx

[sblaisot]

Please add new file to Windows uninstaller.
http://www.mixxx.org/wiki/doku.php/contributing_mappings#windows_installer_update

[Be-ing]

Can you make a wiki page for this?

[JosepMaJAZ]

http://mixxx.org/wiki/doku.php/hardware_compatibility
http://mixxx.org/wiki/doku.php/hercules_dj_console_4-mx

[rryan]

This looks good to me.

At least one forum user is quite happy:

Stunning work :) 

Tested great, with windows 10, 4-MX, and latest version 2.0.0-rc1 (build 1.12 r5678)

[Be-ing]

I'll take a look through this tonight or tomorrow, so please don't merge quite yet.

[JosepMaJAZ]

Yes. The only problem so far is that the lights remain lit when closing mixxx even when I have a shutdown event to do so and the logs say it is being executed. Someday I will need to investigate why.

[Be-ing]

Yes. The only problem so far is that the lights remain lit when closing mixxx even when I have a shutdown event to do so and the logs say it is being executed. Someday I will need to investigate why.

I see that the allLedsOff function is called in the init function too. If there are lights lit on the controller, does that succeed in shutting them off when Mixxx starts or the mapping is loaded?

[Be-ing]

Move this below the introductory comments. Users don't need to care about this.

[sblaisot]

I've seen the same problem (led stay lit on on shutdown despite allLedsOff in shutdown function) on Hercules dj control mp3e2. I even made a bug report for that (on mobile, I don't have the lp number right now).
Not a mixxx problem at first look but I'm interested if you find something.

[Pegasus-RPG]

For the light shut-off, you might try testing with a 250ms sleep in between commands. (I understand some Hercules devices can't handle too many MIDI messages at once.)

[ywwg]

We're cutting the RC2 tonight so I'm going to merge this in despite the style nits. @Be-ing, if you want to propose a cleanup PR for RC3/Release we'd welcome that. @JosepMaJAZ if you figure out a solution to the lights-on problem please feel free to submit it.

[Be-ing]

Okay. I'll make some review comments on this PR then @JosepMaJAZ can open a new PR after making some changes.

[Be-ing]

Regarding the light shutoff, have you tried sending all the MIDI messages from the shutdown function directly without calling another function? Just throwing a guess out there. I have no idea if that will solve the issue.

[Be-ing]

Is this a class compliant USB MIDI and audio device? It works with Linux, right?

[Be-ing]

Vol. Main Controls output volume of your mix

I see this is mapped in the XML file. Does this also affect the sound card's control? Does it need to be mapped to the software gain in Mixxx? If it affects the sound card's output level, it shouldn't also control the software gain.

[Be-ing]

maybe cue_gotoandstop would be more useful? On the other hand, the button has a solid square stop icon on it.

[Be-ing]

I'm confused how the shift button works. The wiki says that pressing it toggles between actions 1-6 and 7-12 for the buttons, but it also says pressing particular buttons with shift does an alternate action which is different from the action of the button when the other layer (1-6 vs 7-12) is active. If I understand the code correctly, pressing and releasing the shift button without pressing any other buttons toggles between actions 1-6 and 7-12, but if another button is pressed before shift is released, it does not switch between 1-6/7-12. Is that correct?

Also, loops are not effects; they're loops. It is confusing to call them effect buttons when they don't control audio effects.

[Be-ing]

Can you move this to the very top of the file?