Add controller Vestax VCI-100MKII

[sohet]

Discontinued but still widely used 4-deck controller. For details, see the wiki http://www.mixxx.org/wiki/doku.php/vestax_vci-100mkii

[illuusio]

Jshint problems found:
Vestax-VCI-100MKII-scripts.js: line 28, col 2, Missing semicolon.
Vestax-VCI-100MKII-scripts.js: line 32, col 2, Missing semicolon.
Vestax-VCI-100MKII-scripts.js: line 90, col 49, Use '===' to compare with '0'.

Those semicolons can be false positives.

[illuusio]

XML prefers '"'-char over '''. It's on the xml-topic tag.

[illuusio]

Please add

////////////////////////////////////////////////////////////////////////
// JSHint configuration                                               //
////////////////////////////////////////////////////////////////////////
/* global engine                                                      */
/* global script                                                      */
/* global print                                                       */
/* global midi                                                        */
////////////////////////////////////////////////////////////////////////

at the top of the javascript-file also seems to be common to have explanation of codes like file: 'Vestax-VCI-300-scripts.js' have.

[illuusio]

if you can run js-beautify to sort code indentation and stuff easily. at least there 'function (' should be 'function('.

[sohet]

Thank you for checking. I believe all the syntactic problems to be removed.

[ywwg]

sohet have you signed our contributor agreement? https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ

[Be-ing]

The wiki page says the button labeled 23 is "Cup". Is this a typo? What does this mean?

[illuusio]

jshint is happy but code format is still incorrect. Too long lines (80 char per line) for example.

[sohet]

Thank you for checking again. I follow the suggestions of js-beautify (python 1.5.10) except wrap. The result of automatic wrap seems ugly, so I wrap the code by hand.

[sohet]

I have signed the agreement just now.

[sohet]

I have had mapped it as usual. But I feel some difficulties.

1. The filter knob of this controller has no mid click stop.
2. The curve of filter assigned to super knob is too critical
   around the mid point.

As a result, I sometimes lose kick and bass, despite my intention to
set it to mid. The knob mapped only hi-pass is far more easy to control.

[sohet]

Some controllers of some manufactures use "CUP" for "cue and play". Same
as "stutter" of Numark. It seems not widely known, so I will describe it
as "Cue and Play".

[sohet]

I notice that XML files automatically produced in ~/.mixxx/controller have the first lines containing single quotes "'".

[Be-ing]

I have had mapped it as usual. But I feel some difficulties.

1. The filter knob of this controller has no mid click stop.
2. The curve of filter assigned to super knob is too critical around the mid point.
   As a result, I sometimes loose kick and bass, despite my intention to set it to mid. The knob mapped only hi-pass is far more easy to control.

That makes sense. It's unfortunate the knob was made that way. Some users will likely still want the default filter superknob behavior or want to change it to control the low pass filter instead of the high pass filter. I'm fine with keeping the mapping as it is, but it would be helpful to mention how to change the mapping to do these on the wiki page.

[illuusio]

I have understood that XML specs favors '"' over ''' and xmllint does it so. I don't know where these automatic created files comes from but they should follow XML-spec.

[sohet]

For the moment, linking the filter description to my article in the forum will help those who want low-high pass. I hope Mixxx will provide option menu that enable users to change the super knob binding.

[sohet]

It seems that Mixxx has come to take care of keylock control at scratch. So I drop it from the script.

[sohet]

If it will take a long time to merge, may I add and change functions as this?
http://www.mixxx.org/forums/viewtopic.php?f=7&t=6038&start=30#p26166

[Be-ing]

No need to merge this before you're ready.

[sohet]

Improve scratching following the scripts of Vestax VCI-400 and Denon MC6000MK2. My implementation uses one loop timer for delay instead of a series of one-shot timers. This improvement also removes interference from jog, so change to inhibit it only in slip mode.

[Be-ing]

Please add a bit more detailed description of the change to your last commit message. To do this, simply run 'git commit --amend' before making another commit.

[Be-ing]

Is this ready to merge?

[illuusio]

LGTM ok me to merge.

[sohet]

[shift + pitch fader] mapping (playposition) seems not so useful, but I can't find an alternative one till now. Please merge it as is.

[ywwg]

we can probably cherry-pick this to 1.12 as well

[Be-ing]

[shift + pitch fader] mapping (playposition) seems not so useful, but I can't find an alternative one till now. Please merge it as is.

Yeah, I just moved a functionality that was mapped to shift + volume fader on my controller. Having a shift function for a fader is really awkward and confusing to actually use.

we can probably cherry-pick this to 1.12 as well

I didn't realize this was targeted at master. Yeah, I don't see why not to cherry pick it into 1.12.

[ywwg]

merged