Skip to content

update description (clarity, consistency, midi channel)#660

Closed
stragu wants to merge 2 commits intomixxxdj:masterfrom
stragu:patch-2
Closed

update description (clarity, consistency, midi channel)#660
stragu wants to merge 2 commits intomixxxdj:masterfrom
stragu:patch-2

Conversation

@stragu
Copy link
Copy Markdown

@stragu stragu commented Jul 26, 2015

I updated the Xone:K2 mapping description so it is clearer, more consistent with the terms used in the manual, and so it includes the info about midi channel 16 being used (instead of the default 15 for this controller, which was mentioned on the forum).

Should this also go to the 1.12 branch? Still not 100% sure how this works.

@daschuer
Copy link
Copy Markdown
Member

Should this also go to the 1.12 branch? Still not 100% sure how this works.

Yes. I can merge this directly to 1.12 if you like. Else you need to debase your changes onto 1.12 and create a new pull request. Github does not allow to re-target this one.

Is there anyone who can confirm your changes?

@stragu
Copy link
Copy Markdown
Author

stragu commented Jul 27, 2015

Yes, please merge to 1.12 when ready, daschuer. I just asked on the forum if a Xone:K2 owner could confirm.

Cheers

@daschuer
Copy link
Copy Markdown
Member

daschuer commented Aug 4, 2015

I have just merged this manually to 1.12
Please sign https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ
to become a Mixxx contributor and comment here when done.

@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Aug 4, 2015

It would be great if you could show how the mapping works with labeled diagrams on the wiki page: http://mixxx.org/wiki/doku.php/allen_heath_xone_k2 . See http://mixxx.org/wiki/doku.php/electrix_tweaker for an example.

@stragu
Copy link
Copy Markdown
Author

stragu commented Aug 4, 2015

Thanks daschuer, I just signed it.
Be-ing, I thought of getting started on it but I am short on time. I might do that when back from holidays. Cheers.

@daschuer
Copy link
Copy Markdown
Member

daschuer commented Aug 5, 2015

Thank you. Do you have a Launchpad account?
I would like to add you to the Contributors group.

@stragu
Copy link
Copy Markdown
Author

stragu commented Aug 6, 2015

Yes, I am stephane-guillou on LP.
Cheers

@daschuer
Copy link
Copy Markdown
Member

daschuer commented Aug 6, 2015

Merged to b12e23f

@daschuer daschuer closed this Aug 6, 2015
@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Oct 30, 2015

Will you be able to finish the wiki page?

@stragu
Copy link
Copy Markdown
Author

stragu commented Dec 29, 2015

Thanks @ferranpujolcamins for creating the diagram, I just had a look to see what needed doing, and there it was! :)

@ferranlala
Copy link
Copy Markdown
Contributor

You are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants