Some fixes to EngineSync#50
Merged
Merged
Conversation
Member
rryan
commented
Jul 19, 2013
rryan
commented
- Supports channels other than [Channel1-4].
- Keeps track of current channel master via a SyncChannel class and not the EngineChannel pointer.
- Removes MIDI stuff -- we should add that later instead of leaving as a stub.
- Some other minor stuff.
…d. Replace "[Master]" with a constant in EngineSync.
…of just Channel1-4. Rename some methods and make them private.
…ections to the control in Mixxx.
…nd instead of groups.
…ter. Store the current beat distance and engine rate controls in SyncChannel itself.
…ing the channel as master fails.
Member
There was a problem hiding this comment.
like my comment style? :P We should clean these up before merging. (but they can stay in the branch for now)
Member
Author
There was a problem hiding this comment.
Ahah yea these debugs and the commentary are funny.
Member
There was a problem hiding this comment.
it makes things easy to see amidst the log spew. I even do this at work :)
Member
|
Have you been testing master sync at all? If so, and these changes don't introduce any obvious bugs, LGTM. |
Member
Author
|
Nope :(. I probably broke things. |
Member
|
This seems to still work! merging. |
11 tasks
Be-ing
referenced
this pull request
in Be-ing/mixxx
Mar 30, 2020
DlgPrefColors: use full palette preview for icons in comboboxes
m0dB
pushed a commit
to m0dB/mixxx
that referenced
this pull request
Jan 21, 2024
update Download page for 2.2.0 release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.