Replace ChannelHandle/ChannelHandleAndGroup with GroupHandle#4843
Closed
Swiftb0y wants to merge 2 commits intomixxxdj:mainfrom
Closed
Replace ChannelHandle/ChannelHandleAndGroup with GroupHandle#4843Swiftb0y wants to merge 2 commits intomixxxdj:mainfrom
Swiftb0y wants to merge 2 commits intomixxxdj:mainfrom
Conversation
Contributor
|
Idea: Hide all metadata (like the group name) behind an opaque handle, namely a plain pointer to a struct with a hidden implementation. All instances are singletons and are never deleted once they have been created. |
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
Bot
added
the
stale
github-actions
Bot
removed
the
stale
Member
|
A ton of conflicts, has this or a derivat already been implemented in the meantime? I'll close this abandoned PR now to clean up the list of open PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.