Numark Scratch: add initial mapping by alhadebe · Pull Request #4834 · mixxxdj/mixxx

alhadebe · 2022-06-30T11:57:31Z

Add Numark Scratch mapping

alhadebe · 2022-06-30T13:16:01Z

Documentation PR is here 492

github-actions · 2022-10-06T00:12:26Z

This PR is marked as stale because it has been open 90 days with no activity.

alhadebe · 2023-03-12T15:33:46Z

@Swiftb0y I'm having trouble getting my head around Javascript. I'm going to need your help to finish this please 🙏🏾

Swiftb0y · 2023-03-13T12:11:01Z

Sure, what exactly do you need help with? I'd be glad to help.

Swiftb0y · 2023-03-13T12:31:30Z

Have you tried out Mixxx 2.4 yet? We added a way to change the effects on the filter knob of the mixer. That would match the way this controller controls effects much more closely.

alhadebe · 2023-03-14T02:36:33Z

Sure, what exactly do you need help with? I'd be glad to help.

My issue is with trying to create components for some of my controls. I think there's unresolved comments from your initial review. The examples I have looked at from other mappings are just too complex for my level I think.

alhadebe · 2023-03-14T03:54:50Z

Have you tried out Mixxx 2.4 yet? We added a way to change the effects on the filter knob of the mixer. That would match the way this controller controls effects much more closely.

Yep I have had a play around, but I have not seen this new system coded out in a mapping. except maybe the s4 k3 but that mapping is above my paygrade.
Where I'm getting stuck is that I borrowed the effects code from the Mixtrack Platinum FX mapping

The other issue is that there is no mixxx SOP on how to map this.

The solution currently in place is
Each fx buttons enable one effect at a time & toggles all other fx buttons off (shift + fx buttons, enables multiple effects)
The Paddle sets super to max and routes both fx units to corresponding deck
this.enablePaddle = function(channel, control, value, _status, _group) {
this.isPaddleHoldOn = value !== 0;
for (var i = 0; i <=2 ; i++) {
engine.setValue("[EffectRack1_EffectUnit" + i + "]", "super1", Math.min(value, 1.0));
engine.setValue("[EffectRack1_EffectUnit" + i + "]", "group_[Channel" + deckNumber + "]_enable", (value !== 0));
}
this.updateEffects();
};
Do you have solutions on how to do this better than what's in my code? I don't know if the new effects system caters for this.
I think we need to come up with consistent way to map these as I have seen on more & more controllers (or maybe it'd just Numark)

**edited (grammar & spelling fix)

Swiftb0y · 2023-03-14T17:38:57Z

+// Default is false. When set to false, the EncoderKnob manages looping. Shift + EncoderKnob scrolls the library/loads track
+// If set to true, the EncoderKnob scrolls the library/loads track. Shift + EncoderKnob manages looping.
+NumarkScratch.invertLoopEncoderFunction = false;


This is really a necessary feature?

With this encoder in Serato, the only option is to press shift + turn to scroll through the library and shift + push to load tracks, every damn time. The default is changing loop length and turning on loops, who uses loops that much, lol?
It's so unintuitive. and I rarely use loops (or haven't taken the time to learn). Numark should really have just added a browse encoder and load buttons. Rant over
Anyway, for this mapping inverting the encoder functions to non-standard is optional. I think this might be helpful to someone else.

That's a fair assessment. As long as it doesn't complicate the design too much, its fine.

Swiftb0y · 2023-03-14T18:10:21Z

Do you have solutions on how to do this better than what's in my code? I don't know if the new effects system caters for this.
I think we need to come up with consistent way to map these as I have seen on more & more controllers (or maybe it'd just Numark)

The problem is that each manufacturer has their own opinion on how many and what effects should be accessible (compare Pioneer, Numark and Denon Prime Hardware). For now, IIUC you can use the "[QuickEffectRack1_[Channel" + i + "]]" loaded_chain_preset CO. IIUC you're supposed to set it to the index of the button. The downside is that the labels of the controller likely don't correspond to the effect actually being used by mixxx (partly stemming from the fact that these differ between manufacturers) but the upside is that you can manually configure your own effects and chains to be used by mixxx instead.

alhadebe · 2023-03-18T06:56:42Z

Do you have solutions on how to do this better than what's in my code? I don't know if the new effects system caters for this.
I think we need to come up with consistent way to map these as I have seen on more & more controllers (or maybe it'd just Numark)

The problem is that each manufacturer has their own opinion on how many and what effects should be accessible (compare Pioneer, Numark and Denon Prime Hardware). For now, IIUC you can use the "[QuickEffectRack1_[Channel" + i + "]]" loaded_chain_preset CO. IIUC you're supposed to set it to the index of the button. The downside is that the labels of the controller likely don't correspond to the effect actually being used by mixxx (partly stemming from the fact that these differ between manufacturers) but the upside is that you can manually configure your own effects and chains to be used by mixxx instead.

@Swiftb0y To double check the mixer's effects are separate & independent from the filter. Will the Quick Effect CO system work still for this use case?

Swiftb0y · 2023-03-18T12:37:55Z

To double check the mixer's effects are separate & independent from the filter. Will the Quick Effect CO system work still for this use case?

Can you elaborate? I'm afraid I don't quite understand what you mean.

alhadebe · 2023-03-30T08:55:51Z

To double check the mixer's effects are separate & independent from the filter. Will the Quick Effect CO system work still for this use case?

Can you elaborate? I'm afraid I don't quite understand what you mean.

From my limited understanding I thought QuickEffects relate to the Filter and the new effect system allows changing the effect for the Filter knob to some other effect for controllers like the s4 mk3 and prime 4.

I'm having a hard time wrapping my head on how I can use QuickEffects for the Numark's standalone effects section.

Thanks for the help again.

Swiftb0y · 2023-03-30T11:08:26Z

Ah I see the problem. Numarks concept of FX sections don't map cleanly to either the QuickEffects nor the separate EffectsUnits...

I think it would be best to just use the FX Select Buttons do specify the loaded_chain_preset of the first effects unit. The paddles should then just enable routing to that one fx unit.

What do you think?

alhadebe · 2024-04-26T04:06:59Z

+NumarkScratch.setChannelInput = function(channel, control, value, _status, _group) {
+    const number = (control === 0x57) ? 1 : 2;
+    const channelgroup = "[Channel" + number + "]";
+
+    switch (value) {
+    case 0x00:  // PC and turn on vinyl control
+        engine.setValue(channelgroup, "passthrough", 0);
+        engine.setValue(channelgroup, "vinylcontrol_enabled", 1);
+        break;
+    case 0x02:  // PHONO/LINE and turn off vinyl control
+        engine.setValue(channelgroup, "passthrough", 1);
+        engine.setValue(channelgroup, "vinylcontrol_enabled", 0);
+        break;
+    }
+};


@JoergAtGithub I noticed you have similar code on your Reloop KUT mapping. For some reason on Mixxx startup, Mixxx is not reading the status of the switch even though I get a sysex response. I have to physically toggle the switch, after Mixxx has loaded for the status it to be read.

Could it be my code or is Mixxxx loading too quickly? Would appreciate your help. Besides this, the PR is ready for merging.

Could it be my code or is Mixxx loading too quickly?

If you start mix first with the mapping disabled and then enable it later via the preferences, does it work reliably?
fyi I also have encountered a firmware bug on my NS6II where it sometimes sends the wrong switch value (though this was with the split cue toggle, not the input switches).

if it works with --qml, it might indeed be some sort of data race on startup. In that case, I'd call it acceptable to slightly delay the sysex inquiry message.

@Swiftb0y a 9 second delay works. Seems a little too long imo. Is that acceptable?

the 9sec correlates to how long it takes for Mixxx to open up for me, on Windows.

Could it be my code or is Mixxx loading too quickly?

If you start mix first with the mapping disabled and then enable it later via the preferences, does it work reliably? fyi I also have encountered a firmware bug on my NS6II where it sometimes sends the wrong switch value (though this was with the split cue toggle, not the input switches).

@Swiftb0y , if I start Mixxx first with the mapping disabled and then enable it later via the preferences, it work reliably.
If I also reload the mapping via text editor after Mixxx has fully loaded, it works reliably.

alhadebe · 2024-06-05T10:35:07Z

@Swiftb0y I think this is ready to merge. I'm still having trouble with channel inputs. Mixxx is not setting the control correctly even though the controller reports the state on startup. When using --qml it works correctly though 🤷🏾‍♂️

Swiftb0y

this looks pretty good so far. Just a couple nitpicks if you want to fix them. If not, its fine too, this mapping is very polished already. I'm sorry for forgetting about this until now.

alhadebe · 2024-06-07T01:22:20Z

this looks pretty good so far. Just a couple nitpicks if you want to fix them. If not, its fine too, this mapping is very polished already. I'm sorry for forgetting about this until now.

No worries I'll fix up the nits. I'll take a look when I get home and then confirm once ready. Thanks for the review.

Swiftb0y

last couple nitpicks

Swiftb0y

last nitpick comment.

Swiftb0y

LGTM. thank you for your patience and contribution.

Swiftb0y · 2024-06-12T09:32:57Z

Can you do me a favor and squash all the commits down into a single one before I merge?

alhadebe · 2024-06-12T09:33:52Z

One last thing @Swiftb0y
case 0x7F: // Picnic Bench/Fast Cut
engine.setValue("[Mixer Profile]", "xFaderMode", 0);
engine.setValue("[Mixer Profile]", "xFaderCalibration", 0.9);
engine.setValue("[Mixer Profile]", "xFaderCurve", 7.0);

How far can I push these values? This is meant to be a scratch mixer with the fastest cut possible. Looking at the mixer settings & developer tools, I can set xFaderCalibration to 0.999307 and xFaderCurve to 999.6

Swiftb0y · 2024-06-12T09:45:30Z

I'm actually not sure. These controls are suboptimal anyways. We really need a hybrid setting that combines both modes in Mixxx to a single slider so it can be mapped to the single knob present on most hardware.

Co-Authored-By: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>

alhadebe · 2024-06-12T11:30:39Z

Squashed. Thanks for the review and the lessons @Swiftb0y

I'll investigate the xfadercurve & calibration values and issue another pr if it helps. I also want to introduce settings now that it is available in main.

manual is here pr 492

Swiftb0y · 2024-06-12T11:58:08Z

Squashed. Thanks for the review and the lessons @Swiftb0y

Thanks for your patience ;)

I'll investigate the xfadercurve & calibration values and issue another pr if it helps.

I filed #13363 for the crossfader issue. I'd be very grateful if you'd look into options solving that from the C++ side.

I also want to introduce settings now that it is available in main.

👍

manual is here mixxxdj/manual#492

Yup, saw that. Thank you.

github-actions Bot added the controller mappings label Jun 30, 2022

alhadebe mentioned this pull request Jun 30, 2022

Numark Scratch: Manual mixxxdj/manual#492

Merged

Swiftb0y requested changes Jul 4, 2022

View reviewed changes

github-actions Bot added stale Stale issues that haven't been updated for a long time. and removed stale Stale issues that haven't been updated for a long time. labels Oct 6, 2022

Swiftb0y reviewed Mar 14, 2023

View reviewed changes

alhadebe force-pushed the NumarkScratch branch from 26597a0 to 1a04075 Compare March 15, 2023 09:57

github-actions Bot added build code quality library skins ui labels Mar 15, 2023

Swiftb0y changed the base branch from 2.3 to 2.4 March 15, 2023 10:31

JoergAtGithub removed skins library ui build code quality labels Mar 18, 2023

alhadebe changed the base branch from main to 2.4 April 26, 2024 03:46

alhadebe commented Apr 26, 2024

View reviewed changes

alhadebe requested a review from Swiftb0y June 5, 2024 10:16

Swiftb0y reviewed Jun 6, 2024

View reviewed changes

JoergAtGithub removed skins effects library engine ui build autodj code quality preferences scanner waveform vinylcontrol soundsource browse labels Jun 9, 2024

alhadebe mentioned this pull request Jun 10, 2024

Allow to permanently disable warning message about missing input device #13252

Open

Swiftb0y reviewed Jun 10, 2024

View reviewed changes

Swiftb0y reviewed Jun 11, 2024

View reviewed changes

Comment thread res/controllers/Numark-Scratch-scripts.js

Swiftb0y approved these changes Jun 12, 2024

View reviewed changes

feat(controllers): add new controller mapping for Numark Scratch

9909b16

Co-Authored-By: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>

Uh oh!

Conversation

alhadebe commented Jun 30, 2022

Uh oh!

alhadebe commented Jun 30, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 6, 2022

Uh oh!

alhadebe commented Mar 12, 2023

Uh oh!

Swiftb0y commented Mar 13, 2023

Uh oh!

Swiftb0y commented Mar 13, 2023

Uh oh!

alhadebe commented Mar 14, 2023

Uh oh!

alhadebe commented Mar 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Swiftb0y Mar 14, 2023

Choose a reason for hiding this comment

Uh oh!

alhadebe Mar 15, 2023

Choose a reason for hiding this comment

Uh oh!

Swiftb0y Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Swiftb0y commented Mar 14, 2023

Uh oh!

alhadebe commented Mar 18, 2023

Uh oh!

Swiftb0y commented Mar 18, 2023

Uh oh!

alhadebe commented Mar 30, 2023

Uh oh!

Swiftb0y commented Mar 30, 2023

Uh oh!

alhadebe Apr 26, 2024

Choose a reason for hiding this comment

Uh oh!

Swiftb0y Jun 6, 2024

Choose a reason for hiding this comment

Uh oh!

Swiftb0y Jun 6, 2024

Choose a reason for hiding this comment

Uh oh!

alhadebe Jun 10, 2024

Choose a reason for hiding this comment

Uh oh!

alhadebe Jun 10, 2024

Choose a reason for hiding this comment

Uh oh!

alhadebe commented Jun 5, 2024

Uh oh!

Swiftb0y left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alhadebe commented Jun 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Swiftb0y left a comment

Choose a reason for hiding this comment

Uh oh!

alhadebe commented Mar 14, 2023 •

edited

Loading

Swiftb0y Mar 15, 2023 •

edited

Loading

alhadebe commented Jun 7, 2024 •

edited

Loading

alhadebe commented Jun 12, 2024 •

edited

Loading

alhadebe commented Jun 12, 2024 •

edited

Loading