WTrackMenu: move actions into Auto DJ and Track Files menus by ronso0 · Pull Request #4830 · mixxxdj/mixxx

ronso0 · 2022-06-28T13:19:37Z

https://mixxx.zulipchat.com/#narrow/stream/247619-UI-.26-UX-design/topic/Configurable.20Track.20Menu

daschuer · 2022-06-28T13:57:41Z

I am strongly against this because the Auto DJ top and bottom menu entries are the most used entries during a DJ session. I cannot effort the extra mouse move to a sub menu.

daschuer · 2022-06-28T14:04:50Z

Here is the original discussion:

#1427 (comment)

IMHO the issue that makes it worse is the third "replace" entry. Feel free to remove this.

daschuer · 2022-06-28T15:01:53Z

"Add to Auto DJ (Replace)" has been introduced here: https://bugs.launchpad.net/mixxx/+bug/1566206

This will work for me, not sure if anyone else uses the other load functions often, I don't use them at all:

Add to Auto DJ (top)
Add to Auto DJ (bottom)
Add/Load to ...
** Player
** Sampler
** Playlist
** Crate
** Auto DJ (replace)

What are your most frequent used menu entries?

ronso0 · 2022-06-28T19:57:16Z

Okay, I expected some discussion : )

Auto DJ top and bottom menu entries are the most used entries during a DJ session

During your DJ session : )
IMO if we want to decide based on such arguments we should make a real survey, not amongst devs.

However we will always find someone how "really needs" this and that option, and we will get nowhere but add more and more legitimate actions to the top level of the menu.
That's why I repeatedly argued for making the menu configurable.

What are your most frequent used menu entries?

top > bottom = most used > rarely used + (reasons I don't need other options), unmentioned actions never used
In the tracks table ():

Open in File Browser
Search related tracks
Delete Track File
Double BPM
Hide from Library (oh I can use Del now : )
(drag'n'drop for very rare playlist management, don't use crates anymore since I started 'tagging' via comments)
(Ctrl+Return opens Properties)

In decks:

Delete Track File
Search related tracks
Adjust ReplayGain from deck gain
(open Properties via double click)

I am not motivated to repeat what I wrote on Zulip, I think it's best to discuss details there.
Zulip: Configurable Track Menu
Looking at that right now it seems we won't even reach a concensus to group the file actions :|

daschuer · 2022-06-28T21:04:17Z

It seems to be a major issue, of two different DJing styles.

AutoDJ user: They need Auto DJ top/bottom for almost every track.
No AutoDJ user: They open the library track menu only occasionally and are distracted by the useless AutoDJ menu.

I do have not auto DJ enabled all the time, but I use I use auto DJ all the time to collect possible follow ups. Instant followers I load via double click. I do not use four decks for staging tracks.

A servery does not really help here, because we already know that both groups exists and who wants to judge how many percentage rectifies of introducing a regression.

If the distraction by Auto DJ menu entries is such big that, it rectifies something configurable, or a fancy menu with buttons to put all in one line, or a library column or such, go ahead.

Be-ing · 2022-06-29T15:34:12Z

How about adding keyboard shortcuts for the "Add to AutoDJ" actions while moving them to a submenu?

ronso0 · 2022-06-29T15:56:32Z

How about adding keyboard shortcuts for the "Add to AutoDJ" actions while moving them to a submenu?

We already have all those as [Library],AutoDJAdd....

daschuer · 2022-06-29T16:42:59Z

With keyboard shortcuts, we have in this case zero visual feedback, which is a usability issue.
... apart from the already overcrowded mapping files.

daschuer · 2022-06-29T17:10:13Z

A cool solution would be to add buttons to a single menu entry:
"Add to Auto DJ [↑][↓][!]"
I just wonder if we can make this keyboard accessible.

"https://stackoverflow.com/questions/8358965/is-there-a-way-to-add-a-qwidget-to-a-qmenu-in-qtcreator

ronso0 · 2022-06-29T21:36:04Z

Nice idea, thanks!

maybe the focus issue can be solved:
https://stackoverflow.com/questions/20365663/how-to-control-focus-of-qwidgetactions-child-widgets

fwiw I once looked into QWidgetAction to resolve the styling / focus issue (keyboard vs. mouse focus) with the checkable items in the crate menu, but the conversion wouldn't have been worth the effort.

ronso0 · 2022-06-29T21:41:51Z

With keyboard shortcuts, we have in this case zero visual feedback, which is a usability issue.

Well, that is also the case when an AutoDJ action is selected as double-click action.
There is featureIsLoading and featureLoadingFinished. Could be used for a briefly highlighting the AutoDJ sidebar item.

daschuer · 2022-06-30T12:36:42Z


 void WTrackMenu::createMenus() {
+    if (featureIsEnabled(Feature::AutoDJ)) {
+        m_pAutoDJMenu = new QMenu(this);


This submenu does not work for me ... we have already discussed better options, that why I request a change.

sure. I considered that option off the table by now anyway, the QWigetAction with 3 buttons is much better if we can make it work.
I made a prototype earlier, it works nicely with only minor changes to the AutoDJ slots. Didn't check the focus behavior and styling, yet. Should be manageable though

I already had a working prototype with the [↑] [↓] [!] buttons, even some focus/navigation issues solved ~90%.
and now I can't find it anymore... carelessly cleaned up git stash or local branches?
meeeh.....

does

git reflog

reveal the old commits? Normally they a still there if you have at least committed them.

this didn't point to any usable commit, just [sha1] HEAD@{xxxx}: checkout: moving from trackmenu-autodj-buttons to search-date-span logs, but at least that revealed the branch name.

What helped was creating .git/lost-found.txt with

git fsck --full --no-reflogs --unreachable --lost-found | grep commit | cut -d\ -f3 | xargs -n 1 git log -n 1 --pretty=oneline > .git/lost-found.txt

in there I found the last commit, git checkout [sha1]
et voilà, back ontrack!

Thanks for the hint @daschuer

https://github.com/ronso0/mixxx/tree/auto-dj-buttons

ronso0 added 2 commits June 28, 2022 14:29

WTrackMenu: group AutoDJ actions into submenu

607a3c4

WTrackMenu: group File Browser & Delete from Disk

7c0dfae

github-actions Bot added the ui label Jun 28, 2022

Be-ing closed this Jun 29, 2022

Be-ing reopened this Jun 29, 2022

daschuer requested changes Jun 30, 2022

View reviewed changes

ronso0 marked this pull request as draft July 4, 2022 20:27

ronso0 closed this Aug 28, 2022

ronso0 deleted the autodj-menu branch August 28, 2022 21:56

Uh oh!

Conversation

ronso0 commented Jun 28, 2022

Uh oh!

daschuer commented Jun 28, 2022

Uh oh!

daschuer commented Jun 28, 2022

Uh oh!

daschuer commented Jun 28, 2022

Uh oh!

ronso0 commented Jun 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daschuer commented Jun 28, 2022

Uh oh!

Be-ing commented Jun 29, 2022

Uh oh!

ronso0 commented Jun 29, 2022

Uh oh!

daschuer commented Jun 29, 2022

Uh oh!

daschuer commented Jun 29, 2022

Uh oh!

ronso0 commented Jun 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronso0 commented Jun 29, 2022

Uh oh!

daschuer Jun 30, 2022

Choose a reason for hiding this comment

Uh oh!

ronso0 Jun 30, 2022

Choose a reason for hiding this comment

Uh oh!

ronso0 Aug 26, 2022

Choose a reason for hiding this comment

Uh oh!

daschuer Aug 26, 2022

Choose a reason for hiding this comment

Uh oh!

ronso0 Aug 26, 2022

Choose a reason for hiding this comment

Uh oh!

ronso0 Aug 26, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ronso0 commented Jun 28, 2022 •

edited

Loading

ronso0 commented Jun 29, 2022 •

edited

Loading