Skip to content

Introduction of gsl::not_null<T*>()#4782

Merged
Swiftb0y merged 3 commits intomixxxdj:mainfrom
daschuer:not_null
Jun 12, 2022
Merged

Introduction of gsl::not_null<T*>()#4782
Swiftb0y merged 3 commits intomixxxdj:mainfrom
daschuer:not_null

Conversation

@daschuer
Copy link
Copy Markdown
Member

@daschuer daschuer commented Jun 1, 2022

Windows and MacOs will fail until we have merged the vcpkg update.

@github-actions github-actions Bot added the build label Jun 1, 2022
@daschuer daschuer marked this pull request as draft June 1, 2022 22:37
Swiftb0y
Swiftb0y reviewed Jun 1, 2022
View reviewed changes
Comment thread packaging/debian/control.in
libudev-dev,
# Note: libdjinterop is available within the Mixxx PPA
libdjinterop-dev,
libmsgsl-dev,
Copy link
Copy Markdown
Member

@Swiftb0y Swiftb0y Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we handle this on other linux distros? fedora doesn't package the gsl

Copy link
Copy Markdown
Member Author

@daschuer daschuer Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, as "guidelines-support-library" https://repology.org/project/ms-gsl/versions

Copy link
Copy Markdown
Contributor

@uklotzde uklotzde Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Development-only: guidelines-support-library-devel

Copy link
Copy Markdown
Member

@Swiftb0y Swiftb0y Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I should've looked better.

Comment thread src/engine/readaheadmanager.h Outdated
@daschuer
Copy link
Copy Markdown
Member Author

daschuer commented Jun 10, 2022

@Holzhaus how can we add ms-gsl to Arch Linux?

@Holzhaus
Copy link
Copy Markdown
Member

Holzhaus commented Jun 11, 2022 •
edited
Loading

@Holzhaus how can we add ms-gsl to Arch Linux?

We need to update the docker container and add this: https://archlinux.org/packages/community/any/microsoft-gsl/

We need to update it anyway for Qt 6.3.0.

@daschuer
Copy link
Copy Markdown
Member Author

daschuer commented Jun 11, 2022

I do not know how to do it. Can you take care?

@Holzhaus
Copy link
Copy Markdown
Member

Holzhaus commented Jun 11, 2022

I do not know how to do it. Can you take care?

https://github.com/Holzhaus/mixxx/tree/bump-archlinux-qt6-to-6.3.0

@Swiftb0y
Copy link
Copy Markdown
Member

Swiftb0y commented Jun 12, 2022

@daschuer please rebase. Thanks.

daschuer and others added 3 commits June 12, 2022 13:48
@daschuer daschuer marked this pull request as ready for review June 12, 2022 18:16
@daschuer daschuer requested a review from Swiftb0y June 12, 2022 18:17
Swiftb0y
Swiftb0y approved these changes Jun 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@Swiftb0y Swiftb0y merged commit d5adcf7 into mixxxdj:main Jun 12, 2022
@Swiftb0y Swiftb0y mentioned this pull request Jun 13, 2022
Closed
@daschuer daschuer added this to the 2.4.0 milestone Jun 21, 2022
@daschuer daschuer deleted the not_null branch October 12, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

+1 more reviewer

@uklotzde uklotzde uklotzde left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build

Projects

None yet

Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@daschuer @Holzhaus @Swiftb0y @uklotzde