MC7000: Fix code style issues in the controller script#4754
Closed
fwcd wants to merge 1 commit into
Closed
Conversation
1405533 to
4cf08da
Compare
Contributor
|
Const/let its not working with the current releases of Mixxx, only for the future. So all your improvements will not be able to run on current release. Just my thought but I guess, the shift and jog acceleration should go first, so based to 2.3 branch and the const/let change to 2.4 or main branch. Maybe @Swiftb0y can comment better on this topic. Cheers |
Contributor
|
Fixing the ES6 linter issues on |
|
This PR is marked as stale because it has been open 90 days with no activity. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a bunch of style issues in the script that the pre-commit hook didn't accept, mostly regarding
const/letdeclarations of variables.