library: add '[Library],sort_focused_column' control pushbutton#4749
Merged
Conversation
daschuer
reviewed
May 10, 2022
daschuer
requested changes
May 10, 2022
Member
daschuer
left a comment
daschuer
left a comment
There was a problem hiding this comment.
Thank you. That was quick.
I have left two comments.
ronso0
force-pushed
the
sort_focused_column
branch
from
968a395 to
d950a08
Compare
Member
Author
Yeah, I wanted to use that myself for some time but never took the time to look into it. The bug report was the trigger to finally do it and kill two birds with one stone (I like birds, though). This is ready. |
Co-authored-by: Daniel Schürmann <daschuer@mixxx.org>
ronso0
force-pushed
the
sort_focused_column
branch
from
d950a08 to
6258953
Compare
Member
|
Can you also add this new control to the manual? |
Member
Author
sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.launchpad.net/mixxx/+bug/1969634
There is need for a simple "sort column with cursor on it" button.
Unfortunately
[Library],sort_column_togglecan not be used directly in xml mappings (or equivalent) but requires scripting.[Library],sort_focused_columnis just a wrapper to callslotSortColumnToggle(0)on button press.