Skip to content

Qmllint fixes#4680

Merged
Holzhaus merged 2 commits into
mixxxdj:mainfrom
daschuer:qmllint_fix
Feb 21, 2022
Merged

Qmllint fixes#4680
Holzhaus merged 2 commits into
mixxxdj:mainfrom
daschuer:qmllint_fix

Conversation

@daschuer
Copy link
Copy Markdown
Member

This fixes on remaining qmllint issue.
It can be fixed for qmllint by
parent.parent.parent.group
But than it no longer works in the code.

I guess it is a qmllint bug, but I have not enough experience to report it upstream.

The other issue was introduced by:
#4673

@github-actions github-actions Bot added the build label Feb 16, 2022
@Swiftb0y
Copy link
Copy Markdown
Member

must be a QML lint bug.
Also, the parent is not the actual parent in component hierarchy, but actually the visual parent that has been defined by the QtQuick Scene graph. So accessing the parents chained like in your example likely does not produce the desired result.

@daschuer
Copy link
Copy Markdown
Member Author

does not produce the desired result.

Yes, that just makes qmllint happy. So there are two bugs with qmllint? Are you able to describe this issue as an upstream bug?

@daschuer
Copy link
Copy Markdown
Member Author

So we can merge this for now?

@Holzhaus Holzhaus merged commit 580090f into mixxxdj:main Feb 21, 2022
@daschuer daschuer deleted the qmllint_fix branch October 12, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants