QML: Mark required properties as such#4654
Merged
Merged
Conversation
Holzhaus
force-pushed
the
qml-required-property
branch
from
634f0bb to
897c485
Compare
uklotzde
reviewed
Feb 1, 2022
uklotzde
approved these changes
Feb 1, 2022
Member
|
I'll take a look tomorrow. I need to read up on the details or |
Contributor
|
As long as the CI builds succeeds merging QML PRs is acceptable. @Swiftb0y Please press merge if you don't spot any obvious flaws. |
Swiftb0y
approved these changes
Feb 3, 2022
Member
Swiftb0y
left a comment
Swiftb0y
left a comment
There was a problem hiding this comment.
LGTM. Thanks.
Sorry for not taking a look yesterday.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, this was postponed because it only works with Qt 5.15+. In #4649 we dropped support for Qt 5.x anyway, so it makes sense to add it.