Merged
Conversation
to make it available in developer mode, too.
Swiftb0y
reviewed
Dec 18, 2021
ywwg
reviewed
Dec 18, 2021
ronso0
force-pushed
the
search-tweaks
branch
from
bb86006 to
04e9793
Compare
Swiftb0y
reviewed
Dec 22, 2021
Member
Author
|
The last changes (thanks @Swiftb0y) are in a fixup commit. Will squash it after the final LGTM |
Swiftb0y
approved these changes
Dec 23, 2021
ronso0
force-pushed
the
search-tweaks
branch
from
70416a1 to
70ce68d
Compare
ywwg
approved these changes
Dec 26, 2021
Member
Author
|
Oki do, who'll press merge? : ) |
Member
|
I didn't review this myself, but two green checkmarks should suffice :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
WTrackTableViewset the global keyboard shortcutEscwhich would always move focus to the tracks table.Thus
Esccloses the search bar popup BUT also immediately removes the focus from the search bar, which made me grumble too often...This PR removes the
Escshortcut and uses the FocusWidget signals instead (added in #4369 ). Actually kinda straight forward, except with the search bar where I had to use a trick to not capture everyEsckeypress. See the inline description.