Update CHANGELOG.md for 2.3.2#4563
Merged
Holzhaus merged 4 commits intomixxxdj:2.3from Dec 26, 2021
Merged
Conversation
Holzhaus
reviewed
Dec 12, 2021
| ## [2.3.2](https://launchpad.net/mixxx/+milestone/2.3.2) (Unreleased) | ||
|
|
||
| * Improve robustness of file type detection by considering the actual MIME type of the content. [lp:1445885](https://bugs.launchpad.net/mixxx/+bug/1445885) [#4356](https://github.com/mixxxdj/mixxx/pull/4356) [#4357](https://github.com/mixxxdj/mixxx/pull/4357) | ||
| * Fix/Improve Appstream metainfo |
Member
There was a problem hiding this comment.
This should go into a packaging section because it affects package maintainers.
| * Playlist: enable sorting by color [#4352](https://github.com/mixxxdj/mixxx/pull/4352) [lp:1945976](https://bugs.launchpad.net/mixxx/+bug/1945976) | ||
| * CMake: Adjust the download directory and name of external dependencies [#4511](https://github.com/mixxxdj/mixxx/pull/4511) | ||
| * Fix clang compiler warnings [#4551](https://github.com/mixxxdj/mixxx/pull/4551) [#4553](https://github.com/mixxxdj/mixxx/pull/4553) | ||
| * ClangFormat: Enable c++17 formatting [#4557](https://github.com/mixxxdj/mixxx/pull/4557) |
Member
There was a problem hiding this comment.
I think that does not belong into the changelog because it's irrelevant to the user.
| [#4349](https://github.com/mixxxdj/mixxx/pull/4349) | ||
| * Playlist: enable sorting by color [#4352](https://github.com/mixxxdj/mixxx/pull/4352) [lp:1945976](https://bugs.launchpad.net/mixxx/+bug/1945976) | ||
| * CMake: Adjust the download directory and name of external dependencies [#4511](https://github.com/mixxxdj/mixxx/pull/4511) | ||
| * Fix clang compiler warnings [#4551](https://github.com/mixxxdj/mixxx/pull/4551) [#4553](https://github.com/mixxxdj/mixxx/pull/4553) |
Member
There was a problem hiding this comment.
I don't think this needs to be mentioned in the changelog.
| [#4344](https://github.com/mixxxdj/mixxx/pull/4344) | ||
| [#4346](https://github.com/mixxxdj/mixxx/pull/4346) | ||
| [#4349](https://github.com/mixxxdj/mixxx/pull/4349) | ||
| * Playlist: enable sorting by color [#4352](https://github.com/mixxxdj/mixxx/pull/4352) [lp:1945976](https://bugs.launchpad.net/mixxx/+bug/1945976) |
Member
There was a problem hiding this comment.
Suggested change
| * Playlist: enable sorting by color [#4352](https://github.com/mixxxdj/mixxx/pull/4352) [lp:1945976](https://bugs.launchpad.net/mixxx/+bug/1945976) | |
| * Playlist: Enable sorting by color [#4352](https://github.com/mixxxdj/mixxx/pull/4352) [lp:1945976](https://bugs.launchpad.net/mixxx/+bug/1945976) |
| [#4346](https://github.com/mixxxdj/mixxx/pull/4346) | ||
| [#4349](https://github.com/mixxxdj/mixxx/pull/4349) | ||
| * Playlist: enable sorting by color [#4352](https://github.com/mixxxdj/mixxx/pull/4352) [lp:1945976](https://bugs.launchpad.net/mixxx/+bug/1945976) | ||
| * CMake: Adjust the download directory and name of external dependencies [#4511](https://github.com/mixxxdj/mixxx/pull/4511) |
Member
There was a problem hiding this comment.
@uklotzde is this relevant to package maintainers where build servers mustn't access the internet?
If so, this should go into a packaging section. If not, this doesn't need to be mentioned at all.
Member
Author
|
Done |
Member
|
Why are we adding PRs to the 2.3.1 and older changelog sections retroactively? |
Member
Author
I have added #4070, because it was int my Todo list for 2.4 and it turns out it was already part of 2.3.1 That's the only reason. I actually don't mind to keep or remove it. |
Member
|
Thanks for the explanation. Going back and adding PRs we forgot to put into the changelog is fine IMO. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the CHANGELOG for a 2.3.2 release.