Skip to content

Components ES6 rewrite with improvements #4550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Swiftb0y wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Components ES6 rewrite with improvements #4550

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0504c79
Components: rewrite with ES6 classes in version 0.1
Be-ing Aug 1, 2021
6550016
midi-components-0.1: "use-strict" for library
Swiftb0y Aug 5, 2021
7204728
midi-components-0.1: improve Button.types API (breaking)
Swiftb0y Aug 5, 2021
fa00f31
midi-components-0.1: use arrow func where possible
Swiftb0y Aug 5, 2021
762775b
midi-components-0.1: simplify Component.trigger() & .disconnect()
Swiftb0y Aug 5, 2021
bb47432
midi-components-0.1: reorder comparision with constants to be consistent
Swiftb0y Aug 5, 2021
ba58ef6
midi-components-0.1: update link to docs
Swiftb0y Dec 16, 2021
8d5e2f7
midi-components-0.1: improve docs with additional comments
Swiftb0y Dec 22, 2021
dce20b0
midi-components-0.1: replace `else if` with `switch case`
Swiftb0y Dec 22, 2021
92576cb
midi-components-0.1: improve error thrown in default HotcueButton#sen…
Swiftb0y Dec 22, 2021
d28de84
midi-components-0.1: relax TODO ownership
Swiftb0y Dec 22, 2021
9913322
midi-components-0.1: improve array wrap-around logic
Swiftb0y Dec 22, 2021
1d7e97d
midi-components-0.1: replace nested ifs with early returns where poss…
Swiftb0y Dec 22, 2021
a1024c0
midi-components-0.1: add TODO comment about separating the effects
Swiftb0y Dec 22, 2021
f593a5d
midi-components-0.1: remove Pot invert feature
Swiftb0y Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading