minor fixes when compiling with qt6#4549
Merged
uklotzde merged 2 commits intomixxxdj:mainfrom Dec 6, 2021
Merged
Conversation
Holzhaus
requested changes
Dec 2, 2021
Member
Holzhaus
left a comment
Holzhaus
left a comment
There was a problem hiding this comment.
Thanks, I left some comments.
vigsterkr
force-pushed
the
macos-fixes-qt6
branch
from
0525e05 to
fc734b1
Compare
Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>
uklotzde
reviewed
Dec 6, 2021
Holzhaus
approved these changes
Dec 6, 2021
uklotzde
approved these changes
Dec 6, 2021
Contributor
uklotzde
left a comment
uklotzde
left a comment
There was a problem hiding this comment.
Contributor agreement has already been signed. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when compiling on macos monterey CMAKE_OSX_DEPLOYMENT_TARGET requires 10.15 otherwise c++17 filesystem feature is not available.