don't wipe inapplicable sound config immediately#4544
Merged
daschuer merged 1 commit intomixxxdj:2.3from Nov 27, 2021
Merged
Conversation
Member
|
Thank you for picking this up. This part can make use of an overhaul anyway. |
daschuer
requested changes
Nov 26, 2021
Member
|
Seeing that the Jack ApI becoming more and more popular, we may consider the external routing use case in all our future steps. We have for instance the issue that you start Mixxx, connect to an JACK output gapping through the routing stage. If later the user uses QJackControl to re-route the sound, Mixxx is not aware from it and displays wrong Info. I think that can be done by separate the "stream enable" task from the "connect to physical output" task. |
ronso0
force-pushed
the
sound-config-error
branch
3 times, most recently
from
84e42de to
0b95424
Compare
Member
Author
|
Ready! |
Member
Author
|
oh, actually this should go to 2.3 |
ronso0
force-pushed
the
sound-config-error
branch
from
0b95424 to
b570bf5
Compare
Member
Author
|
Rebased, ready again. |
Member
Author
|
No CI except Pull Request Labeler?? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
SoundManageris initialized and previously configured output devices aren't available the config is wiped and the default config is written to disk before the user had a chance to intervene.With this commit the new config (empty default or reconfigured) is written to disk only if the user clicked either Continue (with no outputs) or Reconfigure (and actually set an output device).
WIP though I'd appreciate feedback is this approach is acceptable until Mixxx supports multiple sound config profiles.
I didn't yet manage to comprehend how all sound devices config steps and sound error dialogs play together. I have the feeling that the inapplicable config should be discovered earlier, not just when configured outputs are missing.