Skip to content

Effects refactoring minor changes #4482

Merged
uklotzde merged 5 commits intomixxxdj:effects_refactoringfrom
daschuer:effects_refactoring_6
Oct 25, 2021
Merged

Effects refactoring minor changes #4482
uklotzde merged 5 commits intomixxxdj:effects_refactoringfrom
daschuer:effects_refactoring_6

Conversation

@daschuer
Copy link
Copy Markdown
Member

Here some minor changes and style improvements, found during testing.

@github-actions github-actions Bot added the ui label Oct 24, 2021
@daschuer daschuer mentioned this pull request Oct 24, 2021
17 tasks
@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Oct 24, 2021

/home/runner/work/mixxx/mixxx/src/preferences/dialog/dlgprefeq.cpp: In member function ‘void DlgPrefEQ::slotNumDecksChanged(double)’:
Error: /home/runner/work/mixxx/mixxx/src/preferences/dialog/dlgprefeq.cpp:126:33: error: ‘qEqComboBox’ was not declared in this scope; did you mean ‘pEqComboBox’?
  126 |         gridLayout_3->addWidget(qEqComboBox, deckNo, 1);
      |                                 ^~~~~~~~~~~
      |                                 pEqComboBox
Error: /home/runner/work/mixxx/mixxx/src/preferences/dialog/dlgprefeq.cpp:130:17: error: right operand of comma operator has no effect [-Werror=unused-value]
  130 |                 3,
      |                 ^
Error: /home/runner/work/mixxx/mixxx/src/preferences/dialog/dlgprefeq.cpp:131:17: error: right operand of comma operator has no effect [-Werror=unused-value]
  131 |                 1,
      |                 ^
Error: /home/runner/work/mixxx/mixxx/src/preferences/dialog/dlgprefeq.cpp:132:17: error: right operand of comma operator has no effect [-Werror=unused-value]
  132 |                 1);
      |                 ^
Error: /home/runner/work/mixxx/mixxx/src/preferences/dialog/dlgprefeq.cpp:132:18: error: expected ‘;’ before ‘)’ token
  132 |                 1);
      |                  ^
      |                  ;
Error: /home/runner/work/mixxx/mixxx/src/preferences/dialog/dlgprefeq.cpp:132:19: error: right operand of comma operator has no effect [-Werror=unused-value]
  132 |                 1);
      |                   ^

@daschuer daschuer force-pushed the effects_refactoring_6 branch from f5833f0 to a194d49 Compare October 24, 2021 22:24
@daschuer
Copy link
Copy Markdown
Member Author

Oh sorry, I have messed up one commit when trying to group my random changes reasonable. I have rebased the PR to have all commits building again.

Comment thread src/preferences/dialog/dlgprefeq.cpp Outdated
@uklotzde
Copy link
Copy Markdown
Contributor

LGTM

@uklotzde uklotzde merged commit 5e2bbb2 into mixxxdj:effects_refactoring Oct 25, 2021
@daschuer daschuer deleted the effects_refactoring_6 branch April 14, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants