Effects refactoring minor changes #4482
Merged
uklotzde merged 5 commits intomixxxdj:effects_refactoringfrom Oct 25, 2021
Merged
Effects refactoring minor changes #4482uklotzde merged 5 commits intomixxxdj:effects_refactoringfrom
uklotzde merged 5 commits intomixxxdj:effects_refactoringfrom
Conversation
Contributor
|
f5833f0 to
a194d49
Compare
Member
Author
|
Oh sorry, I have messed up one commit when trying to group my random changes reasonable. I have rebased the PR to have all commits building again. |
uklotzde
suggested changes
Oct 24, 2021
uklotzde
approved these changes
Oct 25, 2021
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here some minor changes and style improvements, found during testing.