Qt6: Re-enable Waveform and WaveformFactory classes#4479
Merged
Be-ing merged 1 commit intomixxxdj:mainfrom Oct 24, 2021
uklotzde:qt6-waveform
Merged
Qt6: Re-enable Waveform and WaveformFactory classes#4479Be-ing merged 1 commit intomixxxdj:mainfrom uklotzde:qt6-waveform
Be-ing merged 1 commit intomixxxdj:mainfrom
uklotzde:qt6-waveform
Conversation
Be-ing
approved these changes
Oct 24, 2021
Contributor
Be-ing
left a comment
Be-ing
left a comment
There was a problem hiding this comment.
These classes don't have any direct dependency on QGLWidget.
Contributor
|
No C++ changes, no need to wait for build-checks on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to exclude these classes. Reduces the number of linker errors by ~40 lines.