Improve description why we don't want to rebased PRs#4464
Merged
uklotzde merged 4 commits intomixxxdj:mainfrom Oct 24, 2021
Merged
Improve description why we don't want to rebased PRs#4464uklotzde merged 4 commits intomixxxdj:mainfrom
uklotzde merged 4 commits intomixxxdj:mainfrom
Conversation
Contributor
|
At least amending commits seems to work well during reviews, see #4341. I am not sure if all of our assumptions regarding squashing and rebasing on GitHub still hold. |
Member
Author
|
Yes, amending works and does not interfere require a new full review. This should be covered by the sentence with the ammendig, I have not touched here. Maybe we should change it as well. As long the last commit is samall, or has a failing CI, ammending can be done at any time, IMHO. The GiHub cabability of keeping old comments has been improved and can be considered as perfect. The sentence should now reflect that. |
Member
Author
|
I have decoupled amending from rebasing. Does it fit your needs? |
ronso0
reviewed
Oct 21, 2021
Co-authored-by: ronso0 <ronso0@mixxx.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.