Skip to content

Help text improvement for the Effect preferences.#4461

Merged
Holzhaus merged 5 commits intomixxxdj:mainfrom
daschuer:effects_refactoring_3
Dec 6, 2021
Merged

Help text improvement for the Effect preferences.#4461
Holzhaus merged 5 commits intomixxxdj:mainfrom
daschuer:effects_refactoring_3

Conversation

@daschuer
Copy link
Copy Markdown
Member

@daschuer daschuer commented Oct 19, 2021

This should be improved now .. hopefully.

@github-actions github-actions Bot added the ui label Oct 19, 2021
@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Oct 21, 2021

I can't tell what changed in the second commit? Unfortunately the diffs Qt Designer creates are unreadable. I can't see a difference after building and running it.

@ronso0
Copy link
Copy Markdown
Member

ronso0 commented Oct 21, 2021

Unfortunately the diffs Qt Designer creates are unreadable.

yes, for example grid items are sometimes shuffled after minor edits, and they're saved in random order it appears. that's why I prefer to edit ui files manually.

@ronso0
Copy link
Copy Markdown
Member

ronso0 commented Oct 21, 2021

The texts are cropped so I can't tell how this is an improvement
2618
image

this PR
image

@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Oct 21, 2021

The first commit looks fine.

@daschuer daschuer mentioned this pull request Oct 21, 2021
Merged
@daschuer
Copy link
Copy Markdown
Member Author

daschuer commented Oct 21, 2021

I have set the line wrap flag, now it looks like this:
grafik

ronso0
ronso0 reviewed Oct 21, 2021
View reviewed changes
Comment thread src/preferences/dialog/dlgprefeffectsdlg.ui Outdated
@ronso0
Copy link
Copy Markdown
Member

ronso0 commented Oct 21, 2021

Btw that screenshot shows that the Meta knob config should be moved above the tabs.

@daschuer @ronso0
Improve text even more.
efb4344 
Co-authored-by: ronso0 <ronso0@mixxx.org>
@daschuer
Copy link
Copy Markdown
Member Author

daschuer commented Oct 21, 2021

Done.

@daschuer daschuer mentioned this pull request Oct 21, 2021
Merged
17 tasks
@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Oct 21, 2021 •
edited
Loading

Btw that screenshot shows that the Meta knob config should be moved above the tabs.

As I have said already, I very much disagree. That is not important and should not be shown so prominently. Please remove the last commit.

@daschuer daschuer force-pushed the effects_refactoring_3 branch from 8e59a04 to efb4344 Compare October 21, 2021 23:17
@daschuer daschuer force-pushed the effects_refactoring branch from b01b342 to 9d3985f Compare October 21, 2021 23:40
@daschuer
Copy link
Copy Markdown
Member Author

daschuer commented Oct 21, 2021

Done

@daschuer daschuer force-pushed the effects_refactoring branch from 9d3985f to 7845142 Compare October 21, 2021 23:45
Be-ing
Be-ing reviewed Oct 22, 2021
View reviewed changes
Comment thread src/preferences/dialog/dlgprefeffectsdlg.ui Outdated
@Be-ing Be-ing deleted the branch mixxxdj:main October 26, 2021 01:49
@Be-ing Be-ing closed this Oct 26, 2021
@Be-ing Be-ing reopened this Oct 26, 2021
@Be-ing Be-ing changed the base branch from effects_refactoring to main October 26, 2021 02:00
@daschuer
Copy link
Copy Markdown
Member Author

daschuer commented Oct 26, 2021

Anything left to do here?

@Holzhaus Holzhaus merged commit 4e25c5f into mixxxdj:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronso0 ronso0 ronso0 left review comments

@Holzhaus Holzhaus Holzhaus approved these changes

+1 more reviewer

@Be-ing Be-ing Be-ing left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daschuer @Be-ing @ronso0 @Holzhaus