Skip to content

This descibes possible causes for a rare crasher with effects. #4460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daschuer wants to merge 2 commits into from
Closed

This descibes possible causes for a rare crasher with effects. #4460

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
926555d
Added a TODO for a probably data race in effectprocessor.
daschuer Oct 19, 2021
3a283b0
Added a TODO for another probably data race in effectprocessor.
daschuer Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/effects/backends/effectprocessor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,11 @@ class EffectProcessorImpl : public EffectProcessor {
const EffectEnableState enableState,
const GroupFeatureState& groupFeatures) final {
EffectSpecificState* pState = m_channelStateMatrix[inputHandle][outputHandle];
// TODO: The state can be null if we are in the deleteStatesForInputChannel() loop.
// A protection against this is missing. Since it can happen the assertion is incorrect
// The memory will be leaked.
// Idea: Skip the processing here?
// Probably related: https://bugs.launchpad.net/mixxx/+bug/1775497
VERIFY_OR_DEBUG_ASSERT(pState != nullptr) {
if (kEffectDebugOutput) {
qWarning() << "EffectProcessorImpl::process could not retrieve"
Expand Down Expand Up @@ -268,6 +273,11 @@ class EffectProcessorImpl : public EffectProcessor {
// m_channelStateMatrix may be accessed concurrently in the audio
// engine thread in loadStatesForInputChannel.

// TODO: How is ensure that the statMap is not accessed during this loop?
// This is called in responds to DISABLE_EFFECT_CHAIN_FOR_INPUT_CHANNEL
// and it looks like that the objects pointed by m_channelStateMatrix
// may be still in use.
// Probably related: https://bugs.launchpad.net/mixxx/+bug/1775497
ChannelHandleMap<EffectSpecificState*>& stateMap =
m_channelStateMatrix[*inputChannel];
for (EffectSpecificState* pState : stateMap) {
Expand Down