Rename variables of type EngineParameter to engineParameters#4459
Merged
Holzhaus merged 1 commit intomixxxdj:effects_refactoringfrom Oct 19, 2021
Merged
Conversation
This finishes the refactoring started in mixxxdj@33405b2
Member
|
Thanks, I guess this makes sense to rename. However, I do believe those kinds of renamings can easily happen on Are the more severe issues ironed out and you're finished with the review? If so, we can merge the effects refactoring branch now and retarget this to |
Member
Author
|
The list of findings is soo long, including some bugs. If this one is OK to you please merge and we can continue. |
ronso0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This finishes the refactoring started in 33405b2