Qt6 Covert art guessing: Pass future to the caller#4449
Merged
Be-ing merged 1 commit intomixxxdj:mainfrom Oct 17, 2021
uklotzde:qt6-coverartutils
Merged
Qt6 Covert art guessing: Pass future to the caller#4449Be-ing merged 1 commit intomixxxdj:mainfrom uklotzde:qt6-coverartutils
Be-ing merged 1 commit intomixxxdj:mainfrom
uklotzde:qt6-coverartutils
Conversation
Contributor
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to adopt the [[nodiscard]] attribute and pass it to the caller where the result is finally discarded explicitly.
Uncontrolled starting of background tasks should be avoided for new code. This is a code smell and only works because Mixxx uses shared, mutable data for
Trackobjects.