LibraryScanner: static_cast<int> qsizetype values for Qt6#4438
Merged
uklotzde merged 1 commit intomixxxdj:mainfrom Oct 17, 2021
Merged
LibraryScanner: static_cast<int> qsizetype values for Qt6#4438uklotzde merged 1 commit intomixxxdj:mainfrom
uklotzde merged 1 commit intomixxxdj:mainfrom
Conversation
Contributor
Be-ing
commented
Oct 16, 2021
[356/695] Building CXX object CMakeFiles/mixxx-lib.dir/src/library/scanner/libraryscanner.cpp.o
../src/library/scanner/libraryscanner.cpp: In member function ‘void LibraryScanner::slotFinishUnhashedScan()’:
../src/library/scanner/libraryscanner.cpp:427:14: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘qsizetype’ {aka ‘long long int’} [-Wformat=]
427 | "%d unchanged directories. "
| ~^
| |
| int
| %lld
......
432 | m_scannerGlobal->verifiedDirectories().size(),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| qsizetype {aka long long int}
../src/library/scanner/libraryscanner.cpp:429:14: warning: format ‘%d’ expects argument of type ‘int’, but argument 6 has type ‘qsizetype’ {aka ‘long long int’} [-Wformat=]
429 | "%d tracks verified from changed/added directories. "
| ~^
| |
| int
| %lld
......
434 | m_scannerGlobal->verifiedTracks().size(),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| qsizetype {aka long long int}
../src/library/scanner/libraryscanner.cpp:430:14: warning: format ‘%d’ expects argument of type ‘int’, but argument 7 has type ‘qsizetype’ {aka ‘long long int’} [-Wformat=]
430 | "%d new tracks.",
| ~^
| |
| int
| %lld
......
435 | m_scannerGlobal->addedTracks().size());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| qsizetype {aka long long int}
uklotzde
approved these changes
Oct 17, 2021
Contributor
uklotzde
left a comment
There was a problem hiding this comment.
LGTM
The usage of qDebug() with the format string is uncommon, but let's leave it as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.