replace deprecated QVariant::canConvert with templated version#4434
Merged
Be-ing merged 1 commit intomixxxdj:mainfrom Oct 16, 2021
Merged
replace deprecated QVariant::canConvert with templated version#4434Be-ing merged 1 commit intomixxxdj:mainfrom
Be-ing merged 1 commit intomixxxdj:mainfrom
Conversation
Swiftb0y
approved these changes
Oct 16, 2021
Member
Swiftb0y
left a comment
Swiftb0y
left a comment
There was a problem hiding this comment.
I don't see anywhere in the Qt docs that the Metatype based version got deprecated, though I guess using the templated version may allow the compiler to optimize more.
Contributor
Author
Member
|
Right, passing the int got deprecated, but passing the member of the QVariant::Type enum is still valid. I'm not sure what overload exactly we were calling in the previous version, but it seemed to be the overload taking the enum member. |
Contributor
Author
|
The enum is an int. QVariant was rewritten in Qt6 to use QMetaType. https://doc.qt.io/qt-6/qtcore-changes-qt6.html#meta-type-system |
Member
|
Sorry, waited for CI yesterday but then forgot to merge once it passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.