Skip to content

Navigation Menu

Appearance settings

- AI CODE CREATION
  GitHub CopilotWrite better code with AI
  GitHub Copilot appDirect agents from issue to merge
  MCP Registry^NewIntegrate external tools
- DEVELOPER WORKFLOWS
  ActionsAutomate any workflow
  CodespacesInstant dev environments
  IssuesPlan and track work
  Code ReviewManage code changes
- APPLICATION SECURITY
  GitHub Advanced SecurityFind and fix vulnerabilities
  Code securitySecure your code as you build
  Secret protectionStop leaks before they start
- EXPLORE
  Why GitHub
  Documentation
  Blog
  Changelog
  Marketplace
View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

mixxxdj / mixxx Public

Notifications You must be signed in to change notification settings
Fork 1.8k
Star 6.8k

Code
Issues 2.4k
Pull requests 398
Actions
Projects
Wiki
Security and quality
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Wiki
Security and quality
Insights

Effects refactoring: loaded effect#4426

Merged

Be-ing merged 8 commits into

mixxxdj:effects_refactoringmixxxdj/mixxx:effects_refactoringfrom

daschuer:effects_refactoring_loaded_effectdaschuer/mixxx:effects_refactoring_loaded_effectCopy head branch name to clipboard

Oct 18, 2021

Conversation Commits8 (8)Checks Files changed

Merged

Effects refactoring: loaded effect#4426
Be-ing merged 8 commits into
mixxxdj:effects_refactoringfrom
daschuer:effects_refactoring_loaded_effect

Commits

Commits on Oct 15, 2021

Rename loaded_effect related variables to match the CO name
daschuer
committed
Remove redundant check in loadEffectWithDefaults()
daschuer
committed
Do not write m_pManifest before we are sure it is actually loaded.
daschuer
committed
Remove redundant copy of default constructed EffectParameterPreset
daschuer
committed
Exit effect parameter presets loop once we have a match to save some CPU cycles
daschuer
committed
Added missing 0 set of loaded_effect when it has been unloaded
daschuer
committed

Commits on Oct 18, 2021

Assert that m_pManifest is null after unloadEffect()
daschuer
committed
Assert for pManifest and pEffectPreset both set or null
daschuer
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.