PlayerManager: replace QString::midRef with QRegularExpressions#4419
Merged
uklotzde merged 1 commit intomixxxdj:mainfrom Oct 14, 2021
Merged
PlayerManager: replace QString::midRef with QRegularExpressions#4419uklotzde merged 1 commit intomixxxdj:mainfrom
uklotzde merged 1 commit intomixxxdj:mainfrom
Conversation
uklotzde
suggested changes
Oct 14, 2021
Contributor
uklotzde
left a comment
uklotzde
left a comment
There was a problem hiding this comment.
Comments apply to all occurrences
Contributor
|
Good decision to use this opportunity for replacing the manual parsing with regexes! |
Be-ing
force-pushed
the
playermanager_regexes
branch
3 times, most recently
from
8dc7f76 to
7e5b5a1
Compare
uklotzde
suggested changes
Oct 14, 2021
QString::midRef has been removed in Qt6.
Be-ing
force-pushed
the
playermanager_regexes
branch
from
7e5b5a1 to
543fc4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QString::midRef has been removed in Qt6.