ParserM3u: rewrite for Qt6 compatibility#4418
Merged
Be-ing merged 1 commit intomixxxdj:mainfrom Oct 14, 2021
Merged
Conversation
Be-ing
force-pushed
the
parserm3u_rewrite
branch
from
7133692 to
f5ba6d6
Compare
uklotzde
suggested changes
Oct 14, 2021
Contributor
uklotzde
left a comment
uklotzde
left a comment
There was a problem hiding this comment.
Only a minor suggestion.
Should we extract all the string constants that are scattered throughout the code? At least extracting kWindowsEncoding would help.
Be-ing
force-pushed
the
parserm3u_rewrite
branch
5 times, most recently
from
1d8cde4 to
dccdc4b
Compare
uklotzde
suggested changes
Oct 14, 2021
QTextStream no longer supports uncommon encodings like Windows-1250 in Qt6: https://bugreports.qt.io/browse/QTBUG-75665
Be-ing
force-pushed
the
parserm3u_rewrite
branch
from
dccdc4b to
7c9ba33
Compare
uklotzde
approved these changes
Oct 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QTextStream no longer supports uncommon encodings like Windows-1250
in Qt6:
https://bugreports.qt.io/browse/QTBUG-75665