Dao cleanup#44
Merged
Merged
Conversation
Conflicts: src/library/libraryscanner.h
Added usage of nice macro LOG_FAILED_QUERY(query) instead of qDebug'ing lastErrors. In libraryscanner.cpp avoid #ifdefs by using Qt's QDir::toNativeSeparators. Changed postfix increment to prefix. Added const to functions signatures.
Added usage of nice macro LOG_FAILED_QUERY(query) instead of qDebug'ing lastErrors. In libraryscanner.cpp avoid #ifdefs by using Qt's QDir::toNativeSeparators. Changed postfix increment to prefix. Added const to functions signatures.
Conflicts: src/library/dao/libraryhashdao.h
Member
There was a problem hiding this comment.
Please leave as pass-by-value because we mutate this list and the caller does not expect that (and reuses it elsewhere).
Alternatively you could pass a const reference and clone the QStringList in this method.
Contributor
Author
There was a problem hiding this comment.
What is preferable? Just leave as is was, right?
Member
There was a problem hiding this comment.
They're roughly equivalent :) leaving as it was works.
Member
|
Thanks for the changes Nazar -- looks good to me other than the pass-by-reference issue I pointed out. |
Contributor
Author
|
Leaved Leaved LibraryHashDAO::updateDirectoryStatuses arguments as it was. |
Member
|
Thank you @troyane |
Merged
11 tasks
uklotzde
pushed a commit
that referenced
this pull request
May 22, 2020
Add hotcue shift controls to Deere & Latenight, refine icons in Tango
Holzhaus
pushed a commit
to Holzhaus/mixxx
that referenced
this pull request
Aug 23, 2020
Keyboard mapping edition update
m0dB
pushed a commit
to m0dB/mixxx
that referenced
this pull request
Jan 21, 2024
Add needed clearfix to get-involved page + misc fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added usage of nice macro LOG_FAILED_QUERY(query) instead of qDebug'ing
lastErrors.
In libraryscanner.cpp avoid #ifdefs by using Qt's
QDir::toNativeSeparators.
Changed postfix increment to prefix.
Added const to functions signatures.