Skip to content

Extract Qt atomic operation wrappers into separate header file #4306

Merged
Be-ing merged 1 commit intomixxxdj:mainfrom
uklotzde:qatomic
Sep 19, 2021
Merged

Extract Qt atomic operation wrappers into separate header file #4306
Be-ing merged 1 commit intomixxxdj:mainfrom
uklotzde:qatomic

Conversation

@uklotzde
Copy link
Copy Markdown
Contributor

Based on #4304 that should be merged first.

@daschuer
Copy link
Copy Markdown
Member

#4304 is merged now. I wonder why the changes are still in the diff here.

Comment thread src/util/compatibility/qatomic.h Outdated
@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Sep 19, 2021

#4304 is merged now. I wonder why the changes are still in the diff here.

GitHub will show the first commit until the branch is rebased on main.

@uklotzde uklotzde marked this pull request as ready for review September 19, 2021 13:03
@uklotzde
Copy link
Copy Markdown
Contributor Author

Rebased and cleaned up the comments.

Copy link
Copy Markdown
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CI

@Be-ing Be-ing merged commit d31c431 into mixxxdj:main Sep 19, 2021
@uklotzde uklotzde deleted the qatomic branch September 19, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants