Skip to content

string utils: fix deprecation warnings with Qt6#4302

Merged
uklotzde merged 1 commit intomixxxdj:mainfrom
Be-ing:string_conversions_qt6
Sep 18, 2021
Merged

string utils: fix deprecation warnings with Qt6#4302
uklotzde merged 1 commit intomixxxdj:mainfrom
Be-ing:string_conversions_qt6

Conversation

@Be-ing
Copy link
Copy Markdown
Contributor

@Be-ing Be-ing commented Sep 18, 2021

No description provided.

Copy link
Copy Markdown
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit 3195bd5 into mixxxdj:main Sep 18, 2021
@Be-ing Be-ing deleted the string_conversions_qt6 branch September 18, 2021 22:34
Comment thread src/util/string.h
return QString::fromUtf16(reinterpret_cast<const char16_t*>(wcs), ilen);
case sizeof(uint):
return QString::fromUcs4(reinterpret_cast<const uint*>(wcs), ilen);
return QString::fromUcs4(reinterpret_cast<const char32_t*>(wcs), ilen);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be nice to adjust the case targets.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants