Skip to content

resolve ambiguous overload of QJSValue constructor#4294

Merged
uklotzde merged 1 commit intomixxxdj:mainfrom
Be-ing:qjsvalue_size
Sep 17, 2021
Merged

resolve ambiguous overload of QJSValue constructor#4294
uklotzde merged 1 commit intomixxxdj:mainfrom
Be-ing:qjsvalue_size

Conversation

@Be-ing
Copy link
Copy Markdown
Contributor

@Be-ing Be-ing commented Sep 17, 2021

required by Qt6

../src/controllers/scripting/legacy/controllerscriptenginelegacy.cpp: In member function ‘bool ControllerScriptEngineLegacy::handleIncomingData(const QByteArray&)’:
../src/controllers/scripting/legacy/controllerscriptenginelegacy.cpp:178:33: error: call of overloaded ‘QJSValue(qsizetype)’ is ambiguous
  178 |     args << QJSValue(data.size());
      |                                 ^
In file included from /usr/include/qt6/QtQml/qjsengine.h:48,
                 from /usr/include/qt6/QtQml/QJSEngine:1,
                 from ../src/controllers/scripting/legacy/controllerscriptenginelegacy.h:4,
                 from ../src/controllers/scripting/legacy/controllerscriptenginelegacy.cpp:1:
/usr/include/qt6/QtQml/qjsvalue.h:113:14: note: candidate: ‘QJSValue::QJSValue(QJSPrimitiveValue&&)’
  113 |     explicit QJSValue(QJSPrimitiveValue &&value);
      |              ^~~~~~~~
/usr/include/qt6/QtQml/qjsvalue.h:104:5: note: candidate: ‘QJSValue::QJSValue(double)’
  104 |     QJSValue(double value);
      |     ^~~~~~~~
/usr/include/qt6/QtQml/qjsvalue.h:103:5: note: candidate: ‘QJSValue::QJSValue(uint)’
  103 |     QJSValue(uint value);
      |     ^~~~~~~~
/usr/include/qt6/QtQml/qjsvalue.h:102:5: note: candidate: ‘QJSValue::QJSValue(int)’
  102 |     QJSValue(int value);
      |     ^~~~~~~~
/usr/include/qt6/QtQml/qjsvalue.h:101:5: note: candidate: ‘QJSValue::QJSValue(bool)’
  101 |     QJSValue(bool value);
      |     ^~~~~~~~
/usr/include/qt6/QtQml/qjsvalue.h:96:12: note: candidate: ‘QJSValue::QJSValue(QJSValue&&)’
   96 |     inline QJSValue(QJSValue && other) : d(other.d) { other.d = 0; }
      |            ^~~~~~~~
/usr/include/qt6/QtQml/qjsvalue.h:93:5: note: candidate: ‘QJSValue::QJSValue(const QJSValue&)’
   93 |     QJSValue(const QJSValue &other);
      |     ^~~~~~~~

required by Qt6

../src/controllers/scripting/legacy/controllerscriptenginelegacy.cpp: In member function ‘bool ControllerScriptEngineLegacy::handleIncomingData(const QByteArray&)’:
../src/controllers/scripting/legacy/controllerscriptenginelegacy.cpp:178:33: error: call of overloaded ‘QJSValue(qsizetype)’ is ambiguous
  178 |     args << QJSValue(data.size());
      |                                 ^
In file included from /usr/include/qt6/QtQml/qjsengine.h:48,
                 from /usr/include/qt6/QtQml/QJSEngine:1,
                 from ../src/controllers/scripting/legacy/controllerscriptenginelegacy.h:4,
                 from ../src/controllers/scripting/legacy/controllerscriptenginelegacy.cpp:1:
/usr/include/qt6/QtQml/qjsvalue.h:113:14: note: candidate: ‘QJSValue::QJSValue(QJSPrimitiveValue&&)’
  113 |     explicit QJSValue(QJSPrimitiveValue &&value);
      |              ^~~~~~~~
/usr/include/qt6/QtQml/qjsvalue.h:104:5: note: candidate: ‘QJSValue::QJSValue(double)’
  104 |     QJSValue(double value);
      |     ^~~~~~~~
/usr/include/qt6/QtQml/qjsvalue.h:103:5: note: candidate: ‘QJSValue::QJSValue(uint)’
  103 |     QJSValue(uint value);
      |     ^~~~~~~~
/usr/include/qt6/QtQml/qjsvalue.h:102:5: note: candidate: ‘QJSValue::QJSValue(int)’
  102 |     QJSValue(int value);
      |     ^~~~~~~~
/usr/include/qt6/QtQml/qjsvalue.h:101:5: note: candidate: ‘QJSValue::QJSValue(bool)’
  101 |     QJSValue(bool value);
      |     ^~~~~~~~
/usr/include/qt6/QtQml/qjsvalue.h:96:12: note: candidate: ‘QJSValue::QJSValue(QJSValue&&)’
   96 |     inline QJSValue(QJSValue && other) : d(other.d) { other.d = 0; }
      |            ^~~~~~~~
/usr/include/qt6/QtQml/qjsvalue.h:93:5: note: candidate: ‘QJSValue::QJSValue(const QJSValue&)’
   93 |     QJSValue(const QJSValue &other);
      |     ^~~~~~~~
Copy link
Copy Markdown
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit c9711b6 into mixxxdj:main Sep 17, 2021
@Be-ing Be-ing deleted the qjsvalue_size branch September 17, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants