Skip to content

rename .desktop file according to Freedesktop standards#4206

Merged
Holzhaus merged 1 commit intomixxxdj:2.3from
Be-ing:desktop_rename
Aug 16, 2021
Merged

rename .desktop file according to Freedesktop standards#4206
Holzhaus merged 1 commit intomixxxdj:2.3from
Be-ing:desktop_rename

Conversation

@Be-ing
Copy link
Copy Markdown
Contributor

@Be-ing Be-ing commented Aug 15, 2021

No description provided.

@Be-ing Be-ing changed the base branch from main to 2.3 August 15, 2021 16:40
@github-actions github-actions Bot added the build label Aug 15, 2021
@uklotzde uklotzde added this to the 2.3.1 milestone Aug 15, 2021
@uklotzde uklotzde added changelog This PR should be included in the changelog packaging/installer labels Aug 15, 2021
Copy link
Copy Markdown
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daschuer Anything to do for Debian packaging?

Unrelated: I noticed that the last entry in the changelog is for 2.2.4 although we already released 2.3.0!

@uklotzde
Copy link
Copy Markdown
Contributor

Seems to comply with the naming conventions: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s02.html

@daschuer
Copy link
Copy Markdown
Member

@daschuer Anything to do for Debian packaging?

Nothing to do, as long as cmake installs the file to /usr/share/applications

@uklotzde
Copy link
Copy Markdown
Contributor

@Holzhaus Do you agree with this change?

@Holzhaus
Copy link
Copy Markdown
Member

@Holzhaus Do you agree with this change?

Yes.

@Holzhaus Holzhaus merged commit 6ccf804 into mixxxdj:2.3 Aug 16, 2021
daschuer added a commit to daschuer/mixxx that referenced this pull request Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build changelog This PR should be included in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants