Fix bad phase seek when starting from preroll.#4093
Merged
Holzhaus merged 1 commit intomixxxdj:2.3from Jul 9, 2021
Merged
Conversation
Member
Author
|
This is a great example of where using magic numbers to mean invalid is bad! |
uklotzde
reviewed
Jul 9, 2021
uklotzde
approved these changes
Jul 9, 2021
We were interpreting all <0 playposition as "invalid", which is not correct. fixes https://bugs.launchpad.net/mixxx/+bug/1930143
Member
Author
|
fwiw I don't think this is minor, this caused some trainwrecks in a set I played because the cue points were just barely before the start of the track. |
Member
|
@ywwg can you take care of the merge to |
Member
Author
yeah sure. I actually wrote it for that and then backported |
Holzhaus
approved these changes
Jul 9, 2021
Member
|
Works fine on my machine. Waiting for CI. |
Member
Author
|
what's the right way to merge to main? do a "git merge 2.3", or do a cherrypick of the commit? |
Member
|
Member
Author
|
pushed to main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were interpreting all <0 playposition as "invalid", which is not correct.
fixes https://bugs.launchpad.net/mixxx/+bug/1930143