Qt6 build system prerequisites#4052
Conversation
Be-ing
force-pushed
the
qt6_prereqs
branch
5 times, most recently
from
3050953 to
2834755
Compare
|
Any ideas why the macOS build is failing now? |
|
Not really, I still need to work on that |
|
Maybe this should wait until switching to vcpkg for macOS dependencies with Qt statically linked. |
Pull Request Test Coverage Report for Build 1102806643
💛 - Coveralls |
Be-ing
force-pushed
the
qt6_prereqs
branch
2 times, most recently
from
7e85af5 to
7dcbf12
Compare
to prepare for Qt6 support
That was needed because the old buildserver scripts installed Qt to a separate prefix from the rest of Mixxx's dependencies. vcpkg does not do that.
|
This is no longer failing on copying the Qt plugins into the macOS package now that we are linking Qt statically on macOS with vcpkg. Ready for review. |
| install_qt5_plugin(Qt5::QGifPlugin BUNDLE_LIBS "${MIXXX_INSTALL_PREFIX}") | ||
| install_qt5_plugin(Qt5::QICOPlugin BUNDLE_LIBS "${MIXXX_INSTALL_PREFIX}") | ||
| install_qt5_plugin(Qt5::QSQLiteDriverPlugin BUNDLE_LIBS "${MIXXX_INSTALL_PREFIX}") | ||
| install_qt5_plugin(QCocoaIntegrationPlugin BUNDLE_LIBS "${MIXXX_INSTALL_PREFIX}") |
There was a problem hiding this comment.
Should this macro be renamed to install_qt_plugin without any version number?
There was a problem hiding this comment.
Should we just remove it now that we're not using it?
There was a problem hiding this comment.
The rest of the build system is written with the assumption that a dynamic build should continue to work.
In this sense I would keep it, even though, we can't verify it and it will suffer rotting.
But it will definitely be helpfull in case we want to switch to a dynamic build later.
There was a problem hiding this comment.
I think it would be better to remove it. Yes, we need to support dynamic linking, but we don't need to do so for macOS.
There was a problem hiding this comment.
@uklotzde what do you think about removing this no longer used code?
There was a problem hiding this comment.
Ok. If it is not used then we should probably remove it. Less and simpler is better.
This is not needed since switching to vcpkg and linking Qt statically.
4 participants
A bit of refactoring before adding an option to build with Qt6 (#4051)