skin: Move legacy skin classes to skin/legacy/#3912
Merged
Conversation
daschuer
approved these changes
May 25, 2021
Member
daschuer
left a comment
daschuer
left a comment
There was a problem hiding this comment.
LGTM
I am unsure about the pre-commit issues. Do you want to add a commit with these automatic changes to avoid future noise in PRs? I don't mind about the listed issues itself.
Member
Author
|
I can, but we usually had the policy to not do mass reformattings, so I intentionally skipped it. If you want, I can add it. |
Member
Author
Contributor
|
I don't mind. Choose whatever you think is reasonable and doesn't waste your precious time ;) |
Member
|
Oh I see. I Initially thought it was only header sorting. That would be to massive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.