Skip to content

CMake: Try to detect hidapi version if not already set#3732

Closed
uklotzde wants to merge 1 commit into
mixxxdj:2.3from
uklotzde:cmake-hidapi-version
Closed

CMake: Try to detect hidapi version if not already set#3732
uklotzde wants to merge 1 commit into
mixxxdj:2.3from
uklotzde:cmake-hidapi-version

Conversation

@uklotzde
Copy link
Copy Markdown
Contributor

@uklotzde uklotzde requested a review from Holzhaus March 19, 2021 19:19
@github-actions github-actions Bot added the build label Mar 19, 2021
@Holzhaus
Copy link
Copy Markdown
Member

Maybe we shouldn't do this after all. We'd need to cache hidapi_VERSION, but then the version will be wrong when updating hidapi without deleting the build dir. Sorry, I didn't think of that before. @uklotzde what do you think?

@uklotzde
Copy link
Copy Markdown
Contributor Author

I wondered who else may initialize hidapi_VERSION? If no one does then let's drop this PR.

@uklotzde uklotzde closed this Mar 19, 2021
@uklotzde uklotzde deleted the cmake-hidapi-version branch March 20, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants