Skip to content

move Linux build instructions to code repo from wiki#3657

Closed
Be-ing wants to merge 2 commits intomixxxdj:2.3from
Be-ing:install_linux
Closed

move Linux build instructions to code repo from wiki#3657
Be-ing wants to merge 2 commits intomixxxdj:2.3from
Be-ing:install_linux

Conversation

@Be-ing
Copy link
Copy Markdown
Contributor

@Be-ing Be-ing commented Feb 25, 2021

The Arch Linux instructions are rather verbose but I don't use Arch so I don't know how to improve them.

@Be-ing Be-ing changed the base branch from main to 2.3 February 25, 2021 02:33
Comment thread INSTALL-Linux.md Outdated
Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>
Copy link
Copy Markdown
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO there should be a single install file.
The only thing that really differs is how to install dependencies and we could just explain what the dependencies are and then put a link to the wiki or refer to a section in the "appendix" of the file for more detailed info how to install dependencies on macOS/Windows/$Distro.

Comment thread INSTALL-Linux.md
Comment on lines +17 to +21
``` sh
sudo dnf groupinstall "Development Tools"
sudo dnf install gcc-c++ ccache qt5-declarative-devel fdk-aac-free
sudo dnf builddep mixxx
```
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be easier to read on the terminal if we indent by 4 spaces instead of using fenced code blocks.

Comment thread INSTALL-Linux.md
Comment on lines +115 to +128
## Non-System Qt

To build Mixxx with a version of Qt older or newer than your distribution's package manager, download the latest [Qt source
code](https://download.qt.io/archive/qt/). For each Qt version, it is available at that link in a directory called "single" and has a filename like `qt-everywhere-src-VERSION.tar.xz`. Extract that archive and compile the source code:

```shell
tar xf qt-everywhere-src-VERSION.tar.xz
cd qt-everywhere-src-VERSION
./configure -prefix /path/to/qt/install -system-sqlite -sql-sqlite -qt-zlib -opensource -confirm-license -nomake examples -nomake tests -skip qt3d -skip qtwebengine
make -j`nproc`
make install
```

Append `-DCMAKE_PREFIX_PATH=/path/to/qt/install` (where `/path/to/qt/install` is the path you used when building Qt) to the cmake configure command to instruct cmake to prefer the Qt version from that path.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed. We can just put a link to Qt's build instructions if it's really deemed necessary to mention this explicitly. But IMHO the better approach is to just explain what CMAKE_PREFIX_PATH can be used to add additional search directories for dependencies.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"... for example to build with non-system Qt (link to our wiki in case our instructions are easier to digest than having to collect it from various stackoverflow answers)

@ronso0 ronso0 added this to the 2.3.0 milestone Mar 4, 2021
@Be-ing Be-ing removed this from the 2.3.0 milestone Mar 8, 2021
@Holzhaus Holzhaus marked this pull request as draft April 5, 2021 13:44
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 5, 2021

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Jul 5, 2021
@Be-ing
Copy link
Copy Markdown
Contributor Author

Be-ing commented Nov 20, 2021

Closing in favor of #4432 which adds a BUILDING.md file documenting the build processes for all supported OSes.

@Be-ing Be-ing closed this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale issues that haven't been updated for a long time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants