Skip to content

Enforce offscreen rendering for all tests#3401

Merged
Be-ing merged 1 commit into
mixxxdj:2.3from
uklotzde:mixxx-test-offscreen
Dec 5, 2020
Merged

Enforce offscreen rendering for all tests#3401
Be-ing merged 1 commit into
mixxxdj:2.3from
uklotzde:mixxx-test-offscreen

Conversation

@uklotzde
Copy link
Copy Markdown
Contributor

@uklotzde uklotzde commented Dec 4, 2020

Enforce offscreen rendering for all tests except benchmark tests.

Background: In the RPM build ctest is invoked through a macro %ctest3 that does not to allow setting initial environment variables. This change finally allows to enable and run the tests in the Fedora build system.

@uklotzde uklotzde added the build label Dec 4, 2020
@uklotzde uklotzde added this to the 2.3.0 milestone Dec 4, 2020
@Holzhaus
Copy link
Copy Markdown
Member

Holzhaus commented Dec 4, 2020

Thanks, this would be nice, but last time I tried the offscreen renderer didn't work on Windows. Maybe because it's not included in the static build? Let's wait for CI.

@uklotzde
Copy link
Copy Markdown
Contributor Author

uklotzde commented Dec 4, 2020

Thanks, this would be nice, but last time I tried the offscreen renderer didn't work on Windows. Maybe because it's not included in the static build? Let's wait for CI.

The tests on Windows stalled with no output. Reverted and pushed a revised version.

@uklotzde
Copy link
Copy Markdown
Contributor Author

uklotzde commented Dec 5, 2020

I am curious to see if all tests will pass on ARM and PowerPC architectures.

@Be-ing Be-ing merged commit 7c804e1 into mixxxdj:2.3 Dec 5, 2020
@Holzhaus
Copy link
Copy Markdown
Member

Holzhaus commented Dec 5, 2020

Can you make a follow up that removes the QT_QPA_PLATFORM_PLUGIN_PATH from the GitHub Actions build workflow? I think with these changes it's not needed anymore.

@uklotzde uklotzde deleted the mixxx-test-offscreen branch December 5, 2020 07:35
@uklotzde
Copy link
Copy Markdown
Contributor Author

uklotzde commented Dec 5, 2020

Can you make a follow up that removes the QT_QPA_PLATFORM_PLUGIN_PATH from the GitHub Actions build workflow? I think with these changes it's not needed anymore.

Ideas how to achieve this in CMakeLists.txt for the mixxx-benchmark target? This would allow complete removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants