Skip to content

fix ANGLE OpenGL issues on Windows#3370

Merged
Be-ing merged 2 commits intomixxxdj:2.3from
Be-ing:angle
Nov 25, 2020
Merged

fix ANGLE OpenGL issues on Windows#3370
Be-ing merged 2 commits intomixxxdj:2.3from
Be-ing:angle

Conversation

@Be-ing
Copy link
Copy Markdown
Contributor

@Be-ing Be-ing commented Nov 25, 2020

This is #3367 with a fixed CMakeLists.txt that actually installs the ANGLE DLLs. I confirmed it works by testing the artifact in my Windows VM.

@Be-ing
Copy link
Copy Markdown
Contributor Author

Be-ing commented Nov 25, 2020

@JoergAtGithub can you test the artifact from the build on my fork to confirm the issues are fixed?

@Be-ing
Copy link
Copy Markdown
Contributor Author

Be-ing commented Nov 25, 2020

Waveform preferences in my Windows VM:
image

@JoergAtGithub
Copy link
Copy Markdown
Member

@JoergAtGithub can you test the artifact from the build on my fork to confirm the issues are fixed?

I confirm that the version from this artifact fixes the issues!

@Be-ing Be-ing merged commit 9083294 into mixxxdj:2.3 Nov 25, 2020
@Be-ing Be-ing deleted the angle branch November 25, 2020 19:51
@daschuer
Copy link
Copy Markdown
Member

Thank you, for fixing this. I have done just a bit single stepping and I am not clear how this ever works without.
I am glad this fixed now maybe some other GL issues are fixed in turn.

@ronso0
Copy link
Copy Markdown
Member

ronso0 commented Nov 26, 2020

Just a side note:
I tested with skins prior to #3144 and on Linux it doesn't fix the skin crashes caused by waveform/spinny gl issues :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants